Opened 10 years ago

Closed 8 years ago

#13274 closed task (fixed)

Add QQ._factor_univariate_polynomial()

Reported by: saraedum Owned by: malb
Priority: trivial Milestone: sage-6.2
Component: commutative algebra Keywords: beginner
Cc: Merged in:
Authors: Julian Rueth Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: 6c85a8f (Commits, GitHub, GitLab) Commit: 6c85a8fb6edf506780d774d677dbb022ec23bd4f
Dependencies: #13272 Stopgaps:

Status badges

Description

As a part of #11731, transfer the code which does the factorization over QQ from sage.rings.polynomial.polynomial_element.Polynomial.factor() to QQ._factor_univariate_polynomial().

Attachments (1)

trac_13274.patch (3.0 KB) - added by saraedum 10 years ago.

Download all attachments as: .zip

Change History (12)

Changed 10 years ago by saraedum

comment:1 Changed 10 years ago by saraedum

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by pbruin

  • Reviewers set to Peter Bruin

The patch no longer applies correctly to Sage 5.10.rc1; can you rebase it?

comment:3 Changed 9 years ago by pbruin

  • Status changed from needs_review to needs_work

comment:4 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:5 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 8 years ago by rws

  • Branch set to u/rws/ticket/13274
  • Created changed from 07/19/12 20:16:04 to 07/19/12 20:16:04
  • Modified changed from 01/30/14 21:20:52 to 01/30/14 21:20:52

comment:7 Changed 8 years ago by rws

  • Commit set to cf8b120400f6489b9cef903592e76a9320bdd118

rebased Julian's patch


New commits:

cf8b120Trac 13274: Added QQ._factor_univariate_polynomial

comment:8 Changed 8 years ago by rws

  • Status changed from needs_work to needs_review

comment:9 Changed 8 years ago by git

  • Commit changed from cf8b120400f6489b9cef903592e76a9320bdd118 to 6c85a8fb6edf506780d774d677dbb022ec23bd4f

Branch pushed to git repo; I updated commit sha1. New commits:

6c85a8fMerge branch 'develop' into ticket/13274

comment:10 Changed 8 years ago by pbruin

  • Status changed from needs_review to positive_review

comment:11 Changed 8 years ago by vbraun

  • Branch changed from u/rws/ticket/13274 to 6c85a8fb6edf506780d774d677dbb022ec23bd4f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.