Changes between Initial Version and Version 1 of Ticket #13244, comment 3


Ignore:
Timestamp:
10/01/12 14:51:21 (9 years ago)
Author:
tscrim
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13244, comment 3

    initial v1  
    22> The patch looks good, even if I am not quite convinced by the trading of time-consumption versus dataspace-usage.
    33
    4 My belief is that this is the better approach since memory/disk space is cheap, especially compared to CPU cycles since it takes seconds. However I would argue that each of these should be implemented as (immutable) singletons unless someone can think of a reason why you would need a true duplicate.
     4My belief is that this is the better approach since memory/disk space is cheap, especially compared to CPU cycles since it takes seconds. However I would argue that each of these should be implemented as (immutable) singletons unless someone can think of a reason why you would need a true duplicate. Perhaps that should be another ticket and this one be set to positive review?
    55
    66Also a minor technical thing, from looking at the patch file I believe the reference in SimplicialComplexExamples() on line 1027 is missing the linking underscore.