Opened 10 years ago

Closed 10 years ago

Last modified 5 years ago

#13233 closed enhancement (fixed)

Add simple SST poset to the posets examples

Reported by: jcbeier Owned by: sage-combinat
Priority: minor Milestone: sage-5.3
Component: combinatorics Keywords: sd40
Cc: jessica@… Merged in: sage-5.3.beta0
Authors: Julie Beier Reviewers: Jessica Striker, Anne Schilling
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

There is a simple poset on the set of semistandard tableaux of a given shape with a given filling that orders based on component-wise comparison of the entries.

Attachments (1)

trac_13233-add_sstposet.patch (2.4 KB) - added by jcbeier 10 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by jcbeier

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by jessicapalencia

Description:

The poset on semistandard tableaux of shape s and largest entry f that is ordered by componentwise comparison of the entries.

comment:3 follow-up: Changed 10 years ago by jessicapalencia

  • Status changed from needs_review to positive_review

comment:4 in reply to: ↑ 3 Changed 10 years ago by aschilling

Hi Jessica and Julie,

Great that you wrote your first patch. I have a couple of requests for the doc tests: First of all, there is a spelling error "certianly". Also, the EXAMPLES are not so useful. It might be a good idea to include a test like

sage: P.vertices()
...
sage: P.cover_relations()

to make sure to really specify the poset in the doctests.

Thanks,

Anne

comment:5 follow-up: Changed 10 years ago by aschilling

  • Status changed from positive_review to needs_work

comment:6 in reply to: ↑ 5 Changed 10 years ago by aschilling

Hi again!

Please also remove all ; at the end of the lines.

Thanks,

Anne

Changed 10 years ago by jcbeier

comment:7 Changed 10 years ago by jcbeier

Thanks Anne for the feedback. New patch uploaded that has the appropriate changes.

comment:8 follow-up: Changed 10 years ago by jcbeier

  • Status changed from needs_work to needs_review

comment:9 in reply to: ↑ 8 Changed 10 years ago by aschilling

Replying to jcbeier:

Looks good now!

Anne

comment:10 Changed 10 years ago by aschilling

  • Reviewers changed from Jessica Striker to Jessica Striker, Anne Schilling
  • Status changed from needs_review to positive_review

comment:11 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.3.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:12 Changed 5 years ago by chapoton

  • Authors changed from J Beier to Julie Beier
Note: See TracTickets for help on using tickets.