Opened 10 years ago

Closed 10 years ago

#13220 closed defect (fixed)

bug in morphisms of chain complexes

Reported by: John Palmieri Owned by: John Palmieri
Priority: minor Milestone: sage-5.2
Component: algebraic topology Keywords: sd40
Cc: Merged in: sage-5.2.rc0
Authors: John Palmieri Reviewers: Marshall Hampton
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The attached patch fixes a bug when defining morphisms of chain complexes: the code was supposed to check that a product of two matrices was zero, but used

A * B.is_zero()

rather than

(A * B).is_zero()

As a result, some valid maps of chain complexes were flagged as invalid. The patch fixes this.

Attachments (1)

trac_13220-chain-complex.patch (2.9 KB) - added by John Palmieri 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by John Palmieri

Status: newneeds_review

Changed 10 years ago by John Palmieri

comment:2 Changed 10 years ago by mhampton

Reviewers: Marshall Hampton
Status: needs_reviewpositive_review

comment:3 Changed 10 years ago by Jeroen Demeyer

Milestone: sage-5.3sage-5.2

comment:4 Changed 10 years ago by Jeroen Demeyer

Merged in: sage-5.2.rc0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.