Opened 10 years ago
Closed 10 years ago
#13216 closed defect (fixed)
one test in lattice polytope should be tagged # random
Reported by: | chapoton | Owned by: | mhampton |
---|---|---|---|
Priority: | blocker | Milestone: | sage-5.2 |
Component: | geometry | Keywords: | random test, polytope |
Cc: | Merged in: | sage-5.2.beta1 | |
Authors: | Frédéric Chapoton | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
in the file sage/geometry/lattice_polytope.py
inside the procedure
def _read_nef_x_partitions(data):
the line
sage: print s
should be replaced by
sage: print s # random
because the result contains a timing result, which does not have a fix value. Inside the same file, three other similar tests do already have this tag.
Attachments (1)
Change History (6)
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
- Work issues add the random keyword deleted
comment:2 Changed 10 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to positive_review
comment:3 Changed 10 years ago by
Thanks a lot. I had to do that because the patchbot protested on my own ticket #13077, having nothing to do with this one (see the failing test on 5.1.rc1 in http://patchbot.sagemath.org/ticket/13077/)
comment:5 Changed 10 years ago by
- Merged in set to sage-5.2.beta1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
How slow is your computer that this test took a measurable (rounded) number of seconds? ;-)
Patch looks good to me!