Opened 7 years ago

Closed 6 years ago

#13212 closed defect (fixed)

discriminant of Hecke algebra is broken

Reported by: AlexGhitza Owned by: craigcitro
Priority: major Milestone: sage-5.12
Component: modular forms Keywords: discriminant hecke beginner sd51
Cc: Merged in: sage-5.12.beta2
Authors: Alejandro Argaez Reviewers: Alex Ghitza
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

----------------------------------------------------------------------
| Sage Version 5.0, Release Date: 2012-05-14                         |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: H = CuspForms(1, 24).hecke_algebra()
sage: H.discriminant()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)

/home/ghitza/<ipython console> in <module>()

/opt/sage-5.0/local/lib/python2.7/site-packages/sage/modular/hecke/algebra.pyc in discriminant(self)
    523         except AttributeError:
    524             pass
--> 525         basis = self.basis()
    526         d = len(basis)
    527         if d <= 1:

/opt/sage-5.0/local/lib/python2.7/site-packages/sage/modular/hecke/algebra.pyc in basis(self)
    472             pass
    473         level = self.level()
--> 474         bound = self.__M.hecke_bound()
    475         dim = self.__M.rank()
    476         if dim == 0:

/opt/sage-5.0/local/lib/python2.7/site-packages/sage/structure/parent.so in sage.structure.parent.Parent.__getattr__ (sage/structure/parent.c:6732)()

/opt/sage-5.0/local/lib/python2.7/site-packages/sage/structure/parent.so in sage.structure.parent.getattr_from_other_class (sage/structure/parent.c:3248)()

AttributeError: 'CuspidalSubmodule_level1_Q_with_category' object has no attribute 'hecke_bound'

Attachments (1)

trac_13212.patch (2.6 KB) - added by ArgaezG 6 years ago.
Sage 5.10

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by davidloeffler

  • Keywords beginner sd51 added

This can be corrected in one line by replacing the call to hecke_bound with sturm_bound.

comment:2 Changed 6 years ago by davidloeffler

Correction: what I posted above is wrong -- this would be dangerous and introduce some odd bugs! Better would be to move the definition of hecke_bound in sage/modular/modsym/subspace.py to sage/modular/hecke/submodule.py. That is, I think, the minimally invasive way to make Hecke algebras of cuspidal modform spaces work properly.

Last edited 6 years ago by davidloeffler (previous) (diff)

Changed 6 years ago by ArgaezG

Sage 5.10

comment:3 Changed 6 years ago by davidloeffler

  • Authors set to Alejandro Argaez
  • Status changed from new to needs_review

comment:4 Changed 6 years ago by AlexGhitza

  • Reviewers set to Alex Ghitza
  • Status changed from needs_review to positive_review

comment:5 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:6 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.12.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.