Opened 10 years ago

Last modified 10 years ago

#13210 closed defect

ATLAS: flush output before os.system() — at Version 4

Reported by: jdemeyer Owned by: tbd
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

When doing something like

./sage -i atlas &>my_log_file

the output to my_log_file will be badly ordered because we're not flushing stdout/stderr before calling system() in spkg-install.

New spkg: (for review, changes not yet committed)

atlas-3.8.4.p2 (Jeroen Demeyer, 6 July 2012)

  • Trac #13210: Flush stdout and stderr before calling system().
  • Detect the Apple linker (which is still unsupported).
  • Remove unneeded .orig files in patches/
  • Remove mmsearch-with-temp-Solaris-fix.c patch (was needed for gcc-4.4.0 on Solaris).
  • Remove copying of patches/*tgz since there are no such files.
  • Use 'patch' for patching.

Change History (4)

comment:1 Changed 10 years ago by leif

AFAIK the "error messages" are suboptimal as well, i.e., at least in some cases exceptions get raised (e.g. KeyError IIRC) and tracebacks printed instead of "Error: <informative text>".

comment:2 Changed 10 years ago by vbraun

I think Python tracebacks are more useful than manual error messages, not less. Of course os.system() doesn't raise exceptions so some amount of manual error messages is unavoidable.

comment:3 Changed 10 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 10 years ago by jdemeyer

  • Description modified (diff)
Note: See TracTickets for help on using tickets.