Opened 7 years ago

Closed 7 years ago

#13176 closed enhancement (fixed)

Upgrade sage-mode to 0.7

Reported by: kcrisman Owned by: was
Priority: minor Milestone: sage-5.2
Component: packages: optional Keywords: sage-mode
Cc: iandrus, ncalexan Merged in:
Authors: Nick Alexander Reviewers: Ivan Andrus
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

There is a little confusion about the latest sage-mode - see, for example, this ask.sagemath.org question. On the more or less official wiki page, it is definitely at 0.7, but on the optional spkg page (and when downloading via sage -i sage-mode one only gets 0.6. This needs an upgrade.

#1861 and #2666 are related, but ancient. The SPKG.txt should at least be updated a little, for sure post 0.7 since the maintainer has changed.

The spkg is located on the wiki: sage-mode-0.7.spkg

Change History (16)

comment:1 Changed 7 years ago by kcrisman

Along the way, note the litany of errors reported with 0.7 at the ask.sagemath question.

comment:2 Changed 7 years ago by kcrisman

With respect to #1861, when upgrading, make sure that somewhere in the documentation, wiki, bitbucket, whatever, there is a place that says this was inspired by ipython.el originally. It sounds like the current version isn't really adapted from it at all, though.

Last edited 7 years ago by kcrisman (previous) (diff)

comment:3 follow-up: Changed 7 years ago by kcrisman

  • Description modified (diff)

#1861's issues have already been dealt with on the wiki, which is more or less official, so that is good now.

The spkg is located here. I see that 0.8 has all the other good changes mentioned at #1861 and elsewhere.

A question about the 0.8 spkg, though perhaps that doesn't belong here:

$ hg st
? emacs/sage-load.el

Ivan, do you think the goal of this ticket should be 0.7 on the optional spkg? If so, then since Nick wrote it, you can review it. For 0.8, though, you'd have to find someone else to review it, and that could take a while. I recommend the former course. In that case we can open another ticket for 0.8, where all these doc issues are 100% taken care of, I already given positive review to that stuff and the spkg qua spkg (well, except for the thing above!).

comment:4 Changed 7 years ago by kcrisman

  • Authors set to Nick Alexander
  • Description modified (diff)
  • Reviewers set to Ivan Andrus
  • Status changed from new to needs_review

comment:5 follow-up: Changed 7 years ago by kcrisman

Oh, one more thing - your 0.8 spkg that you posted on the wiki is called sage_mode not sage-mode, but you'll need to do the latter because otherwise people will do sage -i sage-mode and still get 0.7 or nothing. Probably that was just a typo.

Last edited 7 years ago by kcrisman (previous) (diff)

comment:6 in reply to: ↑ 5 Changed 7 years ago by iandrus

Replying to kcrisman:

Oh, one more thing - your 0.8 spkg that you posted on the wiki is called sage_mode not sage-mode, but you'll need to do the latter because otherwise people will do sage -i sage-mode and still get 0.7 or nothing. Probably that was just a typo.

Well it's not really a typo. The reason I changed it to underscore is because sage uses a dash to separate the version from the spkg so calling sage -i sage actually installs the sage-mode-0.6 package! I think this is bad, so I changed it, but I do need to change the documentation for 0.8.

comment:7 in reply to: ↑ 3 Changed 7 years ago by iandrus

Replying to kcrisman:

A question about the 0.8 spkg, though perhaps that doesn't belong here:

$ hg st
? emacs/sage-load.el

That's a generated file (when the spkg is created). Perhaps it should be generated as part of spkg-install, but it doesn't depend on the version of emacs being used etc. so it's kind of like running autoconf before distributing. I have added it to hgignore so the repository will be clean.

Ivan, do you think the goal of this ticket should be 0.7 on the optional spkg? If so, then since Nick wrote it, you can review it. For 0.8, though, you'd have to find someone else to review it, and that could take a while. I recommend the former course. In that case we can open another ticket for 0.8, where all these doc issues are 100% taken care of, I already given positive review to that stuff and the spkg qua spkg (well, except for the thing above!).

That is a good question. If we want 0.7 to get out that's fine. I can review it, even though there are a few known bugs in it.

comment:8 follow-up: Changed 7 years ago by kcrisman

Replying to iandrus:

Replying to kcrisman:

Oh, one more thing - your 0.8 spkg that you posted on the wiki is called sage_mode not sage-mode, but you'll need to do the latter because otherwise people will do sage -i sage-mode and still get 0.7 or nothing. Probably that was just a typo.

Well it's not really a typo. The reason I changed it to underscore is because sage uses a dash to separate the version from the spkg so calling sage -i sage actually installs the sage-mode-0.6 package!

Yikes! Yeah, and the (few) spkgs in a similar situation are like your new one. Good eye. Maybe this is something that should even be changed for the 0.7 spkg, to be honest... too bad about backward compatibility, but this is pretty important.

I think this is bad, so I changed it, but I do need to change the documentation for 0.8.

Yes. Again, or even 0.7.

If we want 0.7 to get out that's fine. I can review it, even though there are a few known bugs in it.

Well, if you think that 0.8 is bug-free and can get someone to review it, we can do that here too. But your big warnings about being EXPERIMENTAL and so forth kind of made me think that you weren't too keen on that yet :)

comment:9 in reply to: ↑ 8 ; follow-up: Changed 7 years ago by iandrus

Replying to kcrisman:

Replying to iandrus:

Replying to kcrisman:

Oh, one more thing - your 0.8 spkg that you posted on the wiki is called sage_mode not sage-mode, but you'll need to do the latter because otherwise people will do sage -i sage-mode and still get 0.7 or nothing. Probably that was just a typo.

Well it's not really a typo. The reason I changed it to underscore is because sage uses a dash to separate the version from the spkg so calling sage -i sage actually installs the sage-mode-0.6 package!

Yikes! Yeah, and the (few) spkgs in a similar situation are like your new one. Good eye. Maybe this is something that should even be changed for the 0.7 spkg, to be honest... too bad about backward compatibility, but this is pretty important.

But it's been that way for a long time, so IMHO it's not worth recreating the 0.7 spkg just for that. Can you tell I'm lazy? :-)

I think this is bad, so I changed it, but I do need to change the documentation for 0.8.

Yes. Again, or even 0.7.

If we want 0.7 to get out that's fine. I can review it, even though there are a few known bugs in it.

Well, if you think that 0.8 is bug-free and can get someone to review it, we can do that here too. But your big warnings about being EXPERIMENTAL and so forth kind of made me think that you weren't too keen on that yet :)

Well, I've been trying to get it to work with changes in the latest python.el (a complete rewrite that will be in Emacs 24.2 when it gets released). It still doesn't fully work, but neither does 0.7 or before, so releasing 0.8 wouldn't be worse. However, I'm afraid that while updating I may have broken compatibility with the old python.el. Since I build Emacs directly from bzr it's slightly non-trivial (and boring) for me to test with old versions. However, it's something I definitely need to do—I just need to bite the bullet and do it. In fact I'll go do it now...

comment:10 in reply to: ↑ 9 Changed 7 years ago by kcrisman

Yikes! Yeah, and the (few) spkgs in a similar situation are like your new one. Good eye. Maybe this is something that should even be changed for the 0.7 spkg, to be honest... too bad about backward compatibility, but this is pretty important.

But it's been that way for a long time, so IMHO it's not worth recreating the 0.7 spkg just for that. Can you tell I'm lazy? :-)

Not lazy, just more efficient with your time than I am.

So does that mean you are ok with this spkg as is? I mean, it's been out there six months... I mean, if the point of sage-mode is to be functional, not bug-free, and has been for a while, then this is not necessarily horrible. Sage isn't bug-free either. Are the bugs documented? As long as they aren't nasty silent failures, I guess.

Well, I've been trying to get it to work with changes in the latest python.el (a complete rewrite that will be in Emacs 24.2 when it gets released). It still doesn't fully work, but neither does 0.7 or before, so releasing 0.8 wouldn't be worse. However, I'm afraid that while updating I may have broken compatibility with the old python.el. Since I build Emacs directly from bzr it's slightly non-trivial (and boring) for me to test with old versions. However, it's something I definitely need to do—I just need to bite the bullet and do it. In fact I'll go do it now...

Just let me know, or (better) open your own ticket for that, then, and let's get this out the door. I can only review the dumb stuff like above, since I don't use, nor know how to use, nor have interest in learning how to use, emacs.

comment:11 Changed 7 years ago by iandrus

  • Description modified (diff)
  • Status changed from needs_review to positive_review

comment:12 Changed 7 years ago by iandrus

I gave it positive review since all the bugs I know about in 0.7 also exist in 0.6. I tested on Emacs 24.1 and Emacs 23.1 on OS X 10.6.8.

comment:13 Changed 7 years ago by kcrisman

Probably makes sense to at least test that it builds on Linux and/or Solaris, though one would assume that Emacs, if anything was pretty portable! Sort of the point, right?

comment:14 Changed 7 years ago by jdemeyer

  • Component changed from user interface to optional packages
  • Description modified (diff)

comment:15 Changed 7 years ago by schilly

spkg moved to the servers

comment:16 Changed 7 years ago by jdemeyer

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.