Opened 9 years ago

Closed 9 years ago

#13164 closed defect (fixed)

Update Givaro to 3.7.1

Reported by: vbraun Owned by: cpernet
Priority: minor Milestone: sage-5.4
Component: finite rings Keywords: SPARC givaro bus error spkg
Cc: jpflori Merged in: sage-5.4.beta1
Authors: Paulo César Pereira de Andrade, Martin Albrecht, Jean-Pierre Flori Reviewers: Volker Braun
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: Commit:
Dependencies: #12840, #12841, to be merged with #12883 Stopgaps:

Status badges

Description (last modified by jpflori)

With Givaro 3.7.0, the test-crt in the Givaro test suite fails on SPARC with the following backtrace:

-bash-3.00$ /home/vbraun/opt/mark/gdb-7.4.1/gdb/gdb test-crt
GNU gdb (GDB) 7.4.1
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "sparc-sun-solaris2.10".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from
/home/vbraun/opt/mark/sage-5.1.beta3/spkg/build/givaro-3.7.0/src/tests/test-crt...done.
(gdb) run
Starting program:
/home/vbraun/opt/mark/sage-5.1.beta3/spkg/build/givaro-3.7.0/src/tests/test-crt
[Thread debugging using libthread_db enabled]
[New Thread 1 (LWP 1)]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1 (LWP 1)]
0x00029030 in Givaro::GFqDom<long>::GFqDom (this=0x7eaec, F=...)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givgfq.h:100
100                     _dcharacteristic = F._dcharacteristic;
(gdb) bt
#0  0x00029030 in Givaro::GFqDom<long>::GFqDom (this=0x7eaec, F=...)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givgfq.h:100
#1  0x00033c3c in Givaro::GivaroMM<Givaro::GFqDom<long> >::initone
(p=0x7eaec, V=...)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givaromm.h:297
#2  0x00031110 in Givaro::GivaroMM<Givaro::GFqDom<long> >::initialize
(bloc=0x7eaec, s=15, V=...)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givaromm.h:300
#3  0x000268f8 in Givaro::Array0<Givaro::GFqDom<long> >::build
(this=0xffbff890, s=15, t=...)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givarray0.inl:30
#4  0x00021ad0 in Givaro::Array0<Givaro::GFqDom<long> >::Array0
(this=0xffbff890, s=15)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givarray0.inl:39
#5  0x0001bf04 in tmain<Givaro::GFqDom<long> > (argc=1,
argv=0xffbffb3c, generator=...) at test-crt.C:49
#6  0x00013d00 in main (argc=1, argv=0xffbffb3c) at test-crt.C:151
(gdb) l
95              {
96                      zero = F.zero;
97                      one = F.one;
98                      mOne = F.mOne;
99                      _characteristic = F._characteristic;
100                     _dcharacteristic = F._dcharacteristic;
101                     _exponent = F._exponent;
102                     _irred = F._irred;
103                     _q = F._q;
104                     _qm1 = F._qm1;

This is related to placement new in the Givaro array class, which we do not use in Sage at this point. Nevertheless it would be nice to clean this up eventually.

Updating Givaro to 3.7.1 fixes the problem. Use spkg at http://perso.telecom-paristech.fr/~flori/sage/givaro-3.7.1.spkg

Attachments (2)

givaro-3.7.1.diff (1.9 KB) - added by jpflori 9 years ago.
Spkg diff, for review only. Committed in spkg.
trac_9511_givaro_3_7_x.patch (21.5 KB) - added by vbraun 9 years ago.
Patch from #9511

Download all attachments as: .zip

Change History (14)

comment:1 Changed 9 years ago by vbraun

  • Report Upstream changed from Reported upstream. Developers acknowledge bug. to Fixed upstream, in a later stable release.

This will be fixed in Givaro-3.7.1, which is scheduled to appear in July 2012.

comment:2 Changed 9 years ago by jpflori

  • Cc jpflori added

givaro 3.7.1 was released on 11/07/2012.

comment:3 Changed 9 years ago by jpflori

I've packaged an updated spkg (just updating the src dir, no problems on linux) at http://perso.telecom-paristech.fr/~flori/sage/givaro-3.7.1.spkg

No changes committed in yet (all in a queue patch).

comment:4 Changed 9 years ago by vbraun

I'll review it if you commit your changes.

Changed 9 years ago by jpflori

Spkg diff, for review only. Committed in spkg.

comment:5 Changed 9 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Description modified (diff)
  • Keywords spkg added
  • Status changed from new to needs_review
  • Summary changed from Givaro 3.7.0 bus error on SPARC Solaris to Update Givaro to 3.7.1

SPKG reuploaded with committed changes. I did not have the time to run make ptest on Linux x86_64, and even less on SPARC hardware.

comment:6 Changed 9 years ago by jpflori

  • Dependencies set to #9511

comment:7 Changed 9 years ago by jpflori

make ptest passes on Ubuntu 12.04 on x86_64.

comment:8 Changed 9 years ago by vbraun

  • Status changed from needs_review to positive_review

Fixes the testsuite bug on SPARC. Only minor changes wrt. 3.7.0. Tests fine on x86_64. LGTM

Changed 9 years ago by vbraun

Patch from #9511

comment:9 Changed 9 years ago by vbraun

  • Dependencies changed from #9511 to #12840, #12841, to be merged with #12883
  • Reviewers set to Volker Braun

comment:10 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.3 to sage-5.4

comment:11 Changed 9 years ago by jdemeyer

  • Authors changed from Jean-Pierre Flori to Paulo César Pereira de Andrade, Martin Albrecht, Jean-Pierre Flori

comment:12 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.4.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.