Opened 7 years ago

Closed 7 years ago

#13139 closed defect (fixed)

Bug in IntegerFactorization

Reported by: aapitzsch Owned by: tbd
Priority: major Milestone: sage-5.2
Component: factorization Keywords:
Cc: Merged in: sage-5.2.beta0
Authors: André Apitzsch Reviewers: R. Andrew Ohana
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

sage: from sage.structure.factorization_integer import IntegerFactorization
sage: IntegerFactorization([(3,1)],unsafe=True) 
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)

../local/lib/python2.7/site-packages/sage/structure/factorization_integer.py in __init__(self, x, unit, cr, sort, simplify, unsafe)
     58         if unsafe:
     59             if unit is None:
---> 60                 self._Factorization__unit = sage.rings.integer.ONE
     61             else:
     62                 self._Factorization__unit = unit

NameError: global name 'sage' is not defined

Attachments (1)

trac_13139.patch (4.3 KB) - added by aapitzsch 7 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by aapitzsch

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by ohanar

  • Reviewers set to R. Andrew Ohana
  • Status changed from needs_review to needs_work

Please add a doctest to verify that this bug is fixed.

Changed 7 years ago by aapitzsch

comment:3 Changed 7 years ago by aapitzsch

  • Status changed from needs_work to needs_review

comment:4 Changed 7 years ago by ohanar

  • Status changed from needs_review to positive_review

Ok, looks good to me.

comment:5 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.2.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.