#13124 closed enhancement (fixed)
Updating PolyBoRi to release 0.8.2
Reported by: | AlexanderDreyer | Owned by: | AlexanderDreyer |
---|---|---|---|
Priority: | major | Milestone: | sage-5.2 |
Component: | packages: standard | Keywords: | |
Cc: | PolyBoRi, malb, burcin | Merged in: | sage-5.2.beta1 |
Authors: | Alexander Dreyer | Reviewers: | Martin Albrecht |
Report Upstream: | None of the above - read trac for reasoning. | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
PolyBoRi's next minor release will be out soon. There were no changes of the interface between PolyBoRi 0.8.2 and 0.8.1, so we just have to update the sources from here:
https://sourceforge.net/projects/polybori/files/polybori/0.8.2rc
PolyBoRi 0.8.2 is a bugfix release incorporating all previous patches from Sage.
Current spkg
Change History (24)
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
comment:2 follow-up: ↓ 3 Changed 10 years ago by
- Reviewers set to Martin Albrecht
- installs fine
- doctests pass
- package look okay
Only issue: I think it's our policy not to have .p0 for fresh packages, but just the name. Can you drop the .p0?
comment:3 in reply to: ↑ 2 Changed 10 years ago by
Replying to malb:
Only issue: I think it's our policy not to have .p0 for fresh packages, but just the name. Can you drop the .p0?
No problem, the updated spkg (renamed and changed tag line in SPKG.txt
) is in place, see above.
comment:4 Changed 10 years ago by
- Description modified (diff)
comment:5 Changed 10 years ago by
- Status changed from needs_review to positive_review
All done then. :)
comment:6 Changed 10 years ago by
- Milestone changed from sage-5.1 to sage-5.2
comment:7 Changed 10 years ago by
I just updated the spkg to include the following patch in the upstream sources:
https://bitbucket.org/brickenstein/polybori/changeset/b5c2173f7a43
The issue was discovered in #13133. I don't add .p0
, since the patch will be in PolyBoRi 0.8.2's next rc.
comment:8 follow-up: ↓ 14 Changed 10 years ago by
@malb Staying positive reviewed?
comment:9 follow-ups: ↓ 10 ↓ 13 Changed 10 years ago by
- Status changed from positive_review to needs_work
- Work issues set to version number
Please don't name the spkg version "0.8.2" if polybori-0.8.2 hasn't actually been released! If the upstream version is called "0.8.2rc1", then so should the Sage version be (including in SPKG.txt
).
comment:10 in reply to: ↑ 9 Changed 10 years ago by
comment:11 Changed 10 years ago by
We are currently co-developing. PolyBoRi 0.8.2 will be whatever the result of this ticket is.
comment:12 Changed 10 years ago by
That makes sense, you you should really make sure that the upstream polybori-0.8.2 is identical to the Sage polybori-0.8.2.
Believe me, I have seen this kind of problems in the past with other packages where the upstream version was close to, but not quite equal to the Sage version.
comment:13 in reply to: ↑ 9 Changed 10 years ago by
Replying to jdemeyer:
Please don't name the spkg version "0.8.2" if polybori-0.8.2 hasn't actually been released! If the upstream version is called "0.8.2rc1", then so should the Sage version be (including in
SPKG.txt
).
Because packages like PolyBoRi (and e.g., M4RI) wait for Sage's tests to pass before releasing, this strategy would create unnecessary bureaucracy. We'd do a rcX, Sage includes the package, we another package which is the final.
comment:14 in reply to: ↑ 8 Changed 10 years ago by
comment:15 Changed 10 years ago by
- Status changed from needs_work to positive_review
- Work issues version number deleted
Positive review then.
comment:16 Changed 10 years ago by
Understanding that spkgs could be messed up, I document the source matching here:
> md5sum * 7e077b1838ec7a80adf250d64ed17e38 polybori-0.8.2rc3.tar.gz 872cd541b398de44a602a058286d6a17 polybori-0.8.2.spkg > mkdir orig; tar -C orig -xzf polybori-0.8.2rc3.tar.gz > mkdir spkg; tar -C spkg -xjf polybori-0.8.2.spkg > diff --recursive -u spkg/polybori-0.8.2/src/ orig/polybori-0.8.2/ Only in orig/polybori-0.8.2/: M4RI
comment:17 Changed 10 years ago by
I just noticed that polybori was the culprit for the mult_table0.png
.. files, which is fixed in this version. So please update ;-)
comment:18 Changed 10 years ago by
- Status changed from positive_review to needs_work
Fails to build on hawk
(OpenSolaris? 06.2009-32):
polybori-0.8.2 ==================================================== Extracting package /export/home/buildbot/build/sage/hawk-1/hawk_full/build/sage-5.2.beta0/spkg/standard/polybori-0.8.2.spkg -rw-r--r-- 1 buildbot other 13486080 Jun 29 22:30 /export/home/buildbot/build/sage/hawk-1/hawk_full/build/sage-5.2.beta0/spkg/standard/polybori-0.8.2.spkg Finished extraction **************************************************** Host system: SunOS hawk 5.11 snv_134 i86pc i386 i86pc **************************************************** C compiler: gcc C compiler version: Using built-in specs. Target: i386-pc-solaris2.11 Configured with: ../gcc-4.4-20100112/configure --with-as=/usr/local/binutils-2.20/bin/as --with-ld=/usr/ccs/bin/ld --with-gmp=/usr/local --with-mpfr=/usr/local Thread model: posix gcc version 4.4.3 20100112 (prerelease) (GCC) **************************************************** Starting build... Removing old PolyBoRi install... Done removing old PolyBoRi install. Running build_polybori... scons: Reading SConscript files ... Platform: sunos5 Platform: sunos5 Platform: sunos5 ValueError: too many values to unpack: File "/export/home/buildbot/build/sage/hawk-1/hawk_full/build/sage-5.2.beta0/spkg/build/polybori-0.8.2/src/SConstruct", line 483: (env, opts) = setup_env(defaultenv) Error building PolyBoRi.
comment:19 Changed 10 years ago by
- Status changed from needs_work to needs_review
I fixed that issue and added an updated spkg at the same place. http://boxen.math.washington.edu/home/dreyer/spkg/polybori-0.8.2.spkg (The previous one archived to polybori-0.8.2.spkg.1)
comment:20 Changed 10 years ago by
- Status changed from needs_review to needs_work
- Work issues set to HTTP 404
The download link gives a 404 Not Found error.
comment:21 Changed 10 years ago by
- Status changed from needs_work to needs_review
- Work issues HTTP 404 deleted
Sorry, I'd accidentally put it to the wrong dir. Now it's at the correct url.
comment:22 Changed 10 years ago by
- Status changed from needs_review to positive_review
Compiles fine on hawk
.
comment:23 Changed 10 years ago by
- Merged in set to sage-5.2.beta1
- Resolution set to fixed
- Status changed from positive_review to closed
comment:24 Changed 10 years ago by
Just for documentation: the sources of polybori-0.8.2.spkg
from sage-5.2.rc0 became release 0.8.2 at https://sourceforge.net/projects/polybori/files/polybori/0.8.2/:
> md5sum polybori-0.8.2.tar.gz polybori-0.8.2.spkg 82649420bae3275138469db6f19aac8e polybori-0.8.2.tar.gz 5d3fb11901c5ab23e34ca3eefbf3028c polybori-0.8.2.spkg > mkdir orig; tar -C orig -xzf polybori-0.8.2.tar.gz > mkdir spkg; tar -C spkg -xjf polybori-0.8.2.spkg > diff --recursive -u spkg/polybori-0.8.2/src/ orig/polybori-0.8.2/ Only in orig/polybori-0.8.2/: M4RI
The spkg is in place now.