Opened 10 years ago

Closed 10 years ago

#13122 closed enhancement (fixed)

Remove last vestiges of darcs from Sage

Reported by: kcrisman Owned by: leif
Priority: minor Milestone: sage-5.1
Component: scripts Keywords:
Cc: kini, robertwb Merged in: sage-5.1.beta6
Authors: R. Andrew Ohana Reviewers: Karl-Dieter Crisman
Report Upstream: Completely fixed; Fix reported upstream Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

#9257 removed one of the last remnants of the darcs revision control system from Sage. Currently we have

$ grep -r darcs Downloads/sage-4.8/devel/sage/
Binary file Downloads/sage-4.8/devel/sage/.hg/store/00manifest.d matches
Binary file Downloads/sage-4.8/devel/sage/.hg/store/data/changes.i matches
Binary file Downloads/sage-4.8/devel/sage/.hg/store/data/commit.i matches
Binary file Downloads/sage-4.8/devel/sage/.hg/store/data/doc/new.i matches
Binary file Downloads/sage-4.8/devel/sage/.hg/store/data/new.i matches
Binary file Downloads/sage-4.8/devel/sage/.hg/store/data/notes.txt.i matches
Binary file Downloads/sage-4.8/devel/sage/.hg/store/data/sage/misc/ matches

which is fine, all repo history. But apparently we still have a file named sage-mirror-darcs-script:

$ grep -r darcs Downloads/sage-5.0/local/bin/
Binary file Downloads/sage-5.0/local/bin/.hg/dirstate matches
Binary file Downloads/sage-5.0/local/bin/.hg/undo.dirstate matches
Downloads/sage-5.0/local/bin/sage-mirror:rsync -axLH --rsh=ssh --delete -r -v  bin/sage-* bin/_darcs modular:/home/was/www/sage/dist/src/scripts-darcs/
Downloads/sage-5.0/local/bin/sage-mirror-darcs-scripts:cd _darcs/
Downloads/sage-5.0/local/bin/sage-mirror-darcs-scripts:rsync -axLH --rsh=ssh --delete -r -v  *

and it's even still in spkg/bin/sage (the old sage-sage)!

$ grep -r darcs Downloads/sage-5.0/spkg/bin/
Downloads/sage-5.0/spkg/bin/sage:if [ "$1" = '-darcs'  -o "$1" = '--darcs' ]; then
Downloads/sage-5.0/spkg/bin/sage:    darcs "$@"

Needless to say,

$ sage -darcs
/Users/.../sage-5.0/spkg/bin/sage: line 606: darcs: command not found

So let's get rid of these last things. Especially if we might be migrating to git in the mid-range future...


Also reported upstream at

Attachments (4)

trac13122_scripts.patch (796 bytes) - added by ohanar 10 years ago.
trac13122_root.patch (542 bytes) - added by ohanar 10 years ago.
trac13122_extcode.patch (533 bytes) - added by ohanar 10 years ago.
trac_13122-reviewer1.patch (486 bytes) - added by kcrisman 10 years ago.

Download all attachments as: .zip

Change History (12)

Changed 10 years ago by ohanar

Changed 10 years ago by ohanar

Changed 10 years ago by ohanar

comment:1 Changed 10 years ago by ohanar

  • Authors set to R. Andrew Ohana
  • Status changed from new to needs_review

This is all of the stuff that I found that is related to darcs. There are other useless scripts that are unused, but that is for another ticket :).

comment:2 Changed 10 years ago by kcrisman

Should we also remove them from .hgignore? Heck, why not. Patch coming up for one of them, and I've submitted an upstream pull request which you should be happy I figured out how to do :)

Changed 10 years ago by kcrisman

comment:3 Changed 10 years ago by kcrisman

  • Description modified (diff)
  • Milestone set to sage-5.2
  • Report Upstream changed from N/A to Completely fixed; Fix reported upstream
  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_review to positive_review

Otherwise I guess this is fine. Everything I find now is either directly related to the changes made here (in .hg/patches etc.), part of the revision history, or part of unrelated files (like Pygments and hgext in our Python).

Patchbot, apply trac13122_scripts.patch, trac13122_root.patch, trac13122_extcode.patch, and trac_13122-reviewer1.patch.

comment:4 Changed 10 years ago by ohanar

  • Description modified (diff)

comment:5 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-5.2 to sage-5.1

comment:6 Changed 10 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 10 years ago by kcrisman

Just FYI, sagenb upstream has just merged the pull request.

comment:8 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.1.beta6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.