Changes between Initial Version and Version 4 of Ticket #13119


Ignore:
Timestamp:
12/17/12 07:31:19 (10 years ago)
Author:
tscrim
Comment:

Hey Mike,

Two minor things:

  • Could you use the auto-linking :func:`on_basis` in the docstring?
  • Since at some point, there is a shift to Python 3, I think we should start using that syntax:
    raise ValueError('Codomain could not be determined')
    

Looks good to me otherwise.

Thanks,
Travis

For patchbot:

Apply only: trac_13119_apply_module_morphism_bugfix-mz.patch

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13119

    • Property Status changed from new to needs_review
    • Property Reviewers changed from to Travis Scrimshaw
  • Ticket #13119 – Description

    initial v4  
    11a potential defect in ._apply_module_morphism function calls list( self.basis().keys() ) when self.is_zero() is True.  This works fine if self.basis() is a finite set, but causes a problem if self.basis() is an infinite set with an iteration function.   In this case, the function hangs trying to list the infinite set.
     2
     3-----
     4
     5Apply only: [attachment:trac_13119_apply_module_morphism_bugfix-mz.patch]