Opened 9 years ago

Closed 9 years ago

#13091 closed defect (fixed)

Bug in graph tensor_product

Reported by: jason Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.1
Component: graph theory Keywords:
Cc: ncohen, dcoudert Merged in: sage-5.1.beta5
Authors: Jason Grout Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:


#12791 introduced a bug in the graph tensor_product if the graph is an undirected graph (only half the edges get added). The bad thing was there was a test that would have uncovered this, but the test output was wrong, so apparently wasn't checked by hand!

I have a patch, but I'm waiting to hear from the person that mentioned this bug to me about who I should credit.

Attachments (1)

trac-13091-tensor_product.patch (1.7 KB) - added by jason 9 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by jason

  • Status changed from new to needs_review

This needs review, but I might change the patch message if the credit line needs to be changed.

Changed 9 years ago by jason

comment:2 Changed 9 years ago by jason

Okay, I fixed the credits in the commit message. This is ready for review.

comment:3 Changed 9 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

Oups, sorry for the mistake.

The patch is working correctly and passes all tests. I give positive review.

comment:4 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.1.beta5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.