Opened 6 years ago

Last modified 2 years ago

#13069 needs_work enhancement

Generation of Double square tiles

Reported by: slabbe Owned by: slabbe
Priority: major Milestone: sage-6.7
Component: combinatorics Keywords: polyomino
Cc: abmasse Merged in:
Authors: Sébastien Labbé Reviewers:
Report Upstream: N/A Work issues:
Branch: public/ticket/13069 (Commits) Commit: ac7f0fea002c126ee44a91c42e94e2b89a79099e
Dependencies: #10054, #13131 Stopgaps:

Description

Add a file into the sage library about double square tiles. Double square tiles are polyominoes which tile the plane in two (regular) ways as a square (i.e. having four neighbors).

This file should go in sage/combinat or sage/combinat/discrete_geometry or sage/combinat/polyomino ?

Reference:

  • Combinatorial properties of double square tiles, A. Blondin Massé, A. Garon, S. Labbé, 2012, to appear.

Attachments (1)

trac_13069_double_square-sl.patch​ (91.1 KB) - added by slabbe 5 years ago.
tested on sage-5.8

Download all attachments as: .zip

Change History (24)

comment:1 Changed 5 years ago by slabbe

  • Status changed from new to needs_review

comment:2 Changed 5 years ago by slabbe

  • Cc abmasse added

comment:3 Changed 5 years ago by slabbe

  • Dependencies set to #10054

comment:4 Changed 5 years ago by chapoton

there are 2 doctests failing, concerning hash values

maybe you could use the doi role :doi:`10.1016/j.tcs.2012.10.040` ?

Changed 5 years ago by slabbe

tested on sage-5.8

comment:5 Changed 5 years ago by slabbe

  • Dependencies changed from #10054 to #10054, #13131

comment:6 Changed 5 years ago by slabbe

In the new patch, I now use sage/misc/table.py. Used doi role and fixed 32-bit vs 64-bit hash values. Needs review!

comment:7 Changed 5 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:8 Changed 5 years ago by chapoton

  • Authors set to Sébastien Labbé
  • Keywords polyomino added

comment:9 Changed 5 years ago by chapoton

  • Branch set to u/chapoton/13069
  • Commit set to 9c7eae1d23eff5b0a5ba86a2d2c9630b68e2c4b5

New commits:

​9c7eae1Add sage/combinat/double_square_tile.py file

comment:10 Changed 4 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:11 Changed 4 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:12 Changed 4 years ago by rws

  • Status changed from needs_review to needs_work
  • Work issues set to rebase

comment:13 Changed 4 years ago by slabbe

  • Branch changed from u/chapoton/13069 to u/slabbe/13069_double_square_tiles
  • Commit changed from 9c7eae1d23eff5b0a5ba86a2d2c9630b68e2c4b5 to bf623a7a8c25d62652bd55cf6b2a34e081a5ca8b

New commits:

​369693cAdd sage/combinat/double_square_tile.py file
​bf623a7Merge sage-6.2 into branch + fix conflicts in combinat index.rst

comment:14 Changed 4 years ago by slabbe

  • Status changed from needs_work to needs_review
  • Work issues rebase deleted

comment:15 Changed 4 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:16 Changed 3 years ago by chapoton

  • Status changed from needs_review to needs_work

needs rebase

comment:17 Changed 3 years ago by chapoton

  • Branch changed from u/slabbe/13069_double_square_tiles to public/ticket/13069_double_square_tiles
  • Commit bf623a7a8c25d62652bd55cf6b2a34e081a5ca8b deleted
  • Status changed from needs_work to needs_review

rebased

comment:18 Changed 3 years ago by chapoton

  • Branch changed from public/ticket/13069_double_square_tiles to public/ticket/13069
  • Commit set to 76783d6b6211eeaee0e9912c9389f222ac57849c

comment:19 Changed 3 years ago by vdelecroix

  • Status changed from needs_review to needs_work

Hello,

  • this is about tiling but we see only one tile at a time... For example, it would be cool to have a parameter translate to plot in order to do: 
    sage: tile.plot(translate=(0,0)) + tile.plot(translate=(x,y))
  • what is the point of verify_definition? I guess its only purpose is for the constructor. If so
    1. make it private
    2. do not use assert but rather raise a ValueError if something is wrong
  • please consider moving figure_11_BGL2012 to sage/tests/. It is not a library function!
  • you should really add definitions, I can not understand what this code is doing. If you want to make it usable, then add documentation. Otherwise, put everything into sage/tests
  • can you fold apply_reduction, reduce_ntimes in one function. It confuses to have different methods doing the same stuff.
  • It is cool to have an AUTHORS section but please one line is enough: 
    - Alexandre Blondin Massé and Sébastien Labbé (2008-2013) - initial version
  • could you move triple_square_example to the examples at the begining (i.e. within the documentation)? or it is important to have it as a standalone function in the library?

More to come Vincent

comment:20 Changed 3 years ago by git

  • Commit changed from 76783d6b6211eeaee0e9912c9389f222ac57849c to 9ded2a586559ccd07500d3d76513797a4e970361

Branch pushed to git repo; I updated commit sha1. New commits:

​66e8e70Merge branch 'public/ticket/13069' into 6.6.rc2
​9ded2a5trac #13069 fixing doctests

comment:21 Changed 3 years ago by chapoton

  • Milestone changed from sage-6.4 to sage-6.7

comment:22 Changed 3 years ago by git

  • Commit changed from 9ded2a586559ccd07500d3d76513797a4e970361 to e8d545efd6d0d266d6e26953542cef7f72f0cb56

Branch pushed to git repo; I updated commit sha1. New commits:

​3acc55aMerge branch 'public/ticket/13069' into 6.7.b2
​e8d545etrac #13069 put raise statements into py3 shape

comment:23 Changed 2 years ago by git

  • Commit changed from e8d545efd6d0d266d6e26953542cef7f72f0cb56 to ac7f0fea002c126ee44a91c42e94e2b89a79099e

Branch pushed to git repo; I updated commit sha1. New commits:

​ac7f0feMerge branch 'public/ticket/13069' into 7.3.b4
Note: See TracTickets for help on using tickets.