Opened 6 years ago
Last modified 2 years ago
#13069 needs_work enhancement
Generation of Double square tiles
Reported by:  slabbe  Owned by:  slabbe 

Priority:  major  Milestone:  sage6.7 
Component:  combinatorics  Keywords:  polyomino 
Cc:  abmasse  Merged in:  
Authors:  Sébastien Labbé  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  public/ticket/13069 (Commits)  Commit:  ac7f0fea002c126ee44a91c42e94e2b89a79099e 
Dependencies:  #10054, #13131  Stopgaps: 
Description
Add a file into the sage library about double square tiles. Double square tiles are polyominoes which tile the plane in two (regular) ways as a square (i.e. having four neighbors).
This file should go in sage/combinat
or sage/combinat/discrete_geometry
or sage/combinat/polyomino
?
Reference:
 Combinatorial properties of double square tiles, A. Blondin Massé, A. Garon, S. Labbé, 2012, to appear.
Attachments (1)
Change History (24)
comment:1 Changed 5 years ago by
 Status changed from new to needs_review
comment:2 Changed 5 years ago by
 Cc abmasse added
comment:3 Changed 5 years ago by
 Dependencies set to #10054
comment:4 Changed 5 years ago by
comment:5 Changed 5 years ago by
 Dependencies changed from #10054 to #10054, #13131
comment:6 Changed 5 years ago by
In the new patch, I now use sage/misc/table.py
. Used doi role and fixed 32bit vs 64bit hash values. Needs review!
comment:7 Changed 5 years ago by
 Milestone changed from sage5.11 to sage5.12
comment:8 Changed 5 years ago by
 Keywords polyomino added
comment:9 Changed 5 years ago by
 Branch set to u/chapoton/13069
 Commit set to 9c7eae1d23eff5b0a5ba86a2d2c9630b68e2c4b5
New commits:
9c7eae1  Add sage/combinat/double_square_tile.py file

comment:10 Changed 4 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:11 Changed 4 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:12 Changed 4 years ago by
 Status changed from needs_review to needs_work
 Work issues set to rebase
comment:13 Changed 4 years ago by
 Branch changed from u/chapoton/13069 to u/slabbe/13069_double_square_tiles
 Commit changed from 9c7eae1d23eff5b0a5ba86a2d2c9630b68e2c4b5 to bf623a7a8c25d62652bd55cf6b2a34e081a5ca8b
comment:14 Changed 4 years ago by
 Status changed from needs_work to needs_review
 Work issues rebase deleted
comment:15 Changed 4 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:17 Changed 3 years ago by
 Branch changed from u/slabbe/13069_double_square_tiles to public/ticket/13069_double_square_tiles
 Commit bf623a7a8c25d62652bd55cf6b2a34e081a5ca8b deleted
 Status changed from needs_work to needs_review
rebased
comment:18 Changed 3 years ago by
 Branch changed from public/ticket/13069_double_square_tiles to public/ticket/13069
 Commit set to 76783d6b6211eeaee0e9912c9389f222ac57849c
comment:19 Changed 3 years ago by
 Status changed from needs_review to needs_work
Hello,
 this is about tiling but we see only one tile at a time... For example, it would be cool to have a parameter
translate
toplot
in order to do:sage: tile.plot(translate=(0,0)) + tile.plot(translate=(x,y))
 what is the point of
verify_definition
? I guess its only purpose is for the constructor. If so make it private
 do not use assert but rather raise a
ValueError
if something is wrong
 please consider moving
figure_11_BGL2012
tosage/tests/
. It is not a library function!  you should really add definitions, I can not understand what this code is doing. If you want to make it usable, then add documentation. Otherwise, put everything into
sage/tests
 can you fold
apply_reduction
,reduce_ntimes
in one function. It confuses to have different methods doing the same stuff.  It is cool to have an
AUTHORS
section but please one line is enough: Alexandre Blondin Massé and Sébastien Labbé (20082013)  initial version
 could you move
triple_square_example
to the examples at the begining (i.e. within the documentation)? or it is important to have it as a standalone function in the library?
More to come Vincent
comment:20 Changed 3 years ago by
 Commit changed from 76783d6b6211eeaee0e9912c9389f222ac57849c to 9ded2a586559ccd07500d3d76513797a4e970361
comment:21 Changed 3 years ago by
 Milestone changed from sage6.4 to sage6.7
comment:22 Changed 3 years ago by
 Commit changed from 9ded2a586559ccd07500d3d76513797a4e970361 to e8d545efd6d0d266d6e26953542cef7f72f0cb56
comment:23 Changed 2 years ago by
 Commit changed from e8d545efd6d0d266d6e26953542cef7f72f0cb56 to ac7f0fea002c126ee44a91c42e94e2b89a79099e
Branch pushed to git repo; I updated commit sha1. New commits:
ac7f0fe  Merge branch 'public/ticket/13069' into 7.3.b4

Note: See
TracTickets for help on using
tickets.
there are 2 doctests failing, concerning hash values
maybe you could use the doi role
:doi:`10.1016/j.tcs.2012.10.040`
?