Opened 11 years ago

Closed 8 years ago

#13063 closed defect (fixed)

Doctesting rst files

Reported by: David Roe Owned by: David Roe
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: doctest framework Keywords:
Cc: Keshav Kini Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12415 Stopgaps:

Status badges

Description

Currently we parse rst files in the documentation in exactly the same way as we parse python files: search for triple quoted strings and then search for sage: within them. This is the wrong approach within an rst file, since doctests can occur within normal text. Instead, we should use docutils to parse the rst files and look for verbatim or doctest blocks, and then search within those.

Change History (9)

comment:1 Changed 11 years ago by David Roe

Cc: Keshav Kini added

comment:2 Changed 10 years ago by David Roe

Component: doctestdoctest framework
Owner: changed from Minh Van Nguyen to David Roe

comment:3 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11sage-5.12

comment:4 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:5 Changed 9 years ago by For batch modifications

Milestone: sage-6.2sage-6.3

comment:6 Changed 8 years ago by For batch modifications

Milestone: sage-6.3sage-6.4

comment:7 in reply to:  description Changed 8 years ago by Jeroen Demeyer

Milestone: sage-6.4sage-duplicate/invalid/wontfix
Reviewers: Jeroen Demeyer
Status: newneeds_review

Replying to roed:

Currently we parse rst files in the documentation in exactly the same way as we parse python files: search for triple quoted strings and then search for sage: within them.

This is simply not true anymore, all files in src/doc/[a-z][a-z] are tested.

comment:8 Changed 8 years ago by Jeroen Demeyer

Status: needs_reviewpositive_review

comment:9 Changed 8 years ago by Volker Braun

Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.