Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#13062 closed enhancement (fixed)

Change parsing of nodoctest

Reported by: roed Owned by: mvngu
Priority: trivial Milestone: sage-5.9
Component: doctest framework Keywords:
Cc: Merged in: sage-5.9.beta2
Authors: David Roe, Jeroen Demeyer Reviewers: Jeroen Demeyer, David Roe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12415, #14331 Stopgaps:

Status badges

Description

Currently Sage will refrain from doctesting a file if the string "nodoctest" is in the first 50 characters. 50 characters is pretty short, and I think it's also good to encourage people to start the line with nodoctest. So I would propose that we change "somewhere in the first 50 characters" to "one of the first 10 lines starts with '# nodocteset' or '.. nodoctest'".

Attachments (2)

13062.patch​ (2.2 KB) - added by roed 8 years ago.
13062_nodoctest_review.patch​ (10.8 KB) - added by jdemeyer 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by roed

comment:1 Changed 8 years ago by roed

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by jdemeyer

I feel like this solution is overkill. Why not simply replace read(50) by read(512)? That should be enough and would probably be more effecient too.

comment:3 Changed 8 years ago by jdemeyer

  • Dependencies changed from #12415 to #12415, #14331

Changed 8 years ago by jdemeyer

comment:4 Changed 8 years ago by jdemeyer

  • Authors set to David Roe, Jeroen Demeyer
  • Reviewers set to Jeroen Demeyer, David Roe

comment:5 Changed 8 years ago by roed

  • Status changed from needs_review to positive_review

Looks fine to me.

comment:6 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.9.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 8 years ago by roed

  • Component changed from doctest to doctest framework
Note: See TracTickets for help on using tickets.