Opened 8 years ago

Last modified 7 years ago

#13058 closed enhancement

Hall-Janko Graph — at Version 13

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.2
Component: graph theory Keywords:
Cc: wdj, kini, dimpase Merged in:
Authors: Nathann Cohen, Dima Pasechnik Reviewers: Keshav Kini, Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12942, #12945, #12952, #12971, #12980, #12981, #12982, #12989, #13038 Stopgaps:

Description (last modified by ncohen)

And heeeeeeeeeere is the Hall-Janko Graph !!

Thank you very much Dima for giving me its recipe :-)

Nathann

Apply:

Change History (18)

comment:1 Changed 8 years ago by ncohen

  • Status changed from new to needs_review

Changed 8 years ago by ncohen

Changed 8 years ago by kini

apply to $SAGE_ROOT/devel/sage

comment:2 Changed 8 years ago by kini

Thanks! Here's a reviewer patch.

For future reference, if you have a long string literal which you want to split into pieces, you can do it by just placing the strings next to each other separated by whitespace: 

>>> "a" "b" == "ab"
True

This is actually more efficient than writing "a" + "b", because it is parsed directly as "ab", whereas with "a" + "b", Python first creates two string objects "a" and "b", and then concatenates them together into a new string object "ab", which essentially causes two useless objects to be created.

I decreased the indentation of some lines in the doctest by two spaces because later, once David Roe's work at #12415 fixes #10458, the ... can be replaced with ....: (two characters more) without making the indent excessively wide.

Last edited 8 years ago by kini (previous) (diff)

comment:3 Changed 8 years ago by kini

  • Reviewers set to Keshav Kini
  • Status changed from needs_review to positive_review

comment:4 Changed 8 years ago by kini

patchbot: apply trac_13058.patch trac_13058.reviewer.patch

comment:5 Changed 8 years ago by dimpase

Hi Nathann, hi Keshav, could you please acknowledge the source of the permutations used (they are from ​http://brauer.maths.qmul.ac.uk/Atlas/v3/permrep/J2G1-p100B0)

Changed 8 years ago by kini

apply to $SAGE_ROOT/devel/sage

comment:6 Changed 8 years ago by kini

Here is a patch which does that.

patchbot: apply trac_13058.patch trac_13058.reviewer.patch trac_13058.attribution.patch

comment:7 Changed 8 years ago by ncohen

  • Status changed from positive_review to needs_work

Hellooooooooo Keshav !! Could you take a look at that ? Dima though that it would be better to make both constructors available, just to check for correction :-)

Nathann

comment:8 Changed 8 years ago by ncohen

  • Status changed from needs_work to needs_review

Changed 8 years ago by ncohen

comment:9 Changed 8 years ago by ncohen

  • Description modified (diff)

comment:10 Changed 8 years ago by kini 

sage: timeit("graphs.HallJankoGraph()")
25 loops, best of 3: 25.1 ms per loop
sage: timeit("graphs.HallJankoGraph(from_string=False)")
5 loops, best of 3: 10.8 s per loop

I added "# long time" to the doctests for from_string=False.

Last edited 8 years ago by kini (previous) (diff)

Changed 8 years ago by kini

apply to $SAGE_ROOT/devel/sage

comment:11 Changed 8 years ago by kini

  • Reviewers changed from Keshav Kini to Keshav Kini, Dima Pasechnik
  • Status changed from needs_review to positive_review

comment:12 Changed 8 years ago by ncohen

Thaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaanks !! :-)

Nathann

comment:13 Changed 8 years ago by ncohen

  • Description modified (diff)
Note: See TracTickets for help on using tickets.