ecl chokes when CC or CXX contains space

[ohanar]

Currently ecl completely fails to build when CC or CXX contains a space. This adds a patch accepted by upstream to fix this.

Upstream (patched): ​http://sage.ugent.be/www/jdemeyer/sage/ecl-15.3.7.tar.bz2

[ddrake]

I can verify that our current ECL chokes with "env CC='nice gcc' ./spkg -i ecl..." and that your spkg fixes it. Perhaps it would be nice to put something into the generated ecl_cc so we know whence it came: maybe a comment like # ECL chokes when CC contains spaces; this script works around that. See #13044. Then it would be easier to remove this workaround when ECL is updated.

Also, I tried env CXX='nice g++' ./sage -f ecl... with the old version and it worked fine. Perhaps we shouldn't also create ecl_cxx since ECL is not using a C++ compiler.

Also^2, we should send this upstream.

[fbissey]

Is this still needed?

[jdemeyer]

Yes, it is still needed.

[pbruin]

This needs to be converted to a new-style package, for the ECL version we currently use.

[embray]

I can confirm this is still an issue--sage build breaks on ecl when CC=ccache gcc--obviously this can be worked around easily enough, but setting CC like that is not uncommon either, and only seems to be a problem with ecl.

Would this be worth patching in ecl (both upstream and in sage)?

[embray]

The updated spkg mentioned in this ticket is a 404 now.

[fbissey]

Current upstream is ​https://common-lisp.net/project/ecl/ Also ecl-16.0.0 has been released and it would be nice to upgrade. It would be worth checking if it is still an issue in the latest release.

[embray]

There is a similar bug that I've just run into, but in Python, when compiling the Cython sources. I've never run into this before strangely, but maybe have just worked on fewer projects with cpp generated from Cython: ​https://bugs.python.org/issue8027

I will check if the ecl issue is fixed upstream.

[embray]

FYI this bug still exists upstream, or at least in ecl-16.0.0. I will see if I can come up with a patch.

[embray]

Submitted a patch to upstream: ​https://gitlab.com/embeddable-common-lisp/ecl/merge_requests/20

[embray]

Added the patch to the spkg. It applies to the current version of the spkg with a bit of fuzz.

If I understand correctly I should also update the patch version, and upload a new source package? Not sure exactly how to go about that though.

---

New commits:

​c9f77c6

Add patch to ecl for building when CC=ccache gcc (or the like) from https://gitlab.com/embeddable-common-lisp/ecl/merge_requests/20

[jdemeyer]

Replying to embray:

Added the patch to the spkg. It applies to the current version of the spkg with a bit of fuzz.

If I understand correctly I should also update the patch version

In this exceptional case I think it's not needed because there is no reason to rebuild everybody's ECL with this patch. And in the cases where ECL didn't install before, there is no rebuild needed since there couldn't have been a build in the first place.

and upload a new source package?

No, because you are not changing the source tarball, just adding a patch.

[embray]

If I understand correctly, for the package the patches are being applied by spkg-src which only seems to apply when building the source tarball.

[jdemeyer]

Okay, this is unusual...

[fbissey]

Bad separation (i.e. none) between the patches that needs to be applied in spkg-src because autoconf has to be run after them and "normal" patches. I guess since you are patching the tarball anyway, you may as well put *all* the patches in it.

[embray]

FWIW the patch has been accepted as-is upstream.

[jdemeyer]

Building with CC="ccache cc" CXX="ccache c++" now works.

I cleaned up the packaging and build of ECL. In particular, I separated the patches which need to be applied by spkg-src from the ones which are applied at build-time. This part still needs to be reviewed.

---

New commits:

​9049b15

Improve ECL packaging and build

[embray]

+1