Opened 10 years ago

Closed 10 years ago

#13035 closed task (fixed)

Cholesky decomposition over RDF/CDF

Reported by: rbeezer Owned by: jason, was
Priority: minor Milestone: sage-5.1
Component: linear algebra Keywords: sd40.5
Cc: ddrake Merged in: sage-5.1.beta3
Authors: Rob Beezer Reviewers: William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This patch primarily moves the code for the Cholesky decomposition up to the "matrix double dense" module, where it belongs, and is consistent with the approach for other decompositions. The SciPy code is general enough to handle RDF/CDF symmetric/Hermitian cases simultaneously so the move is easy.

Side-effects:

  • Significant documentation upgrade.
  • No doctest in matrix2 needs adjustment due to the code change here.
  • First step in un-deprecating the cholesky() method.

The cholesky_decomposition(), _cholesky_decomposition() situation is a total mess and needs fixing. The shorter name is more consistent with others, such as schur() and SVD(). Once the exact version of cholesky() is concluded at #11274, then I plan to get the mess all straightened out. This patch is independent of the ones for the exact matrices, so has no dependencies.

Attachments (2)

trac_13035-cholesky-RDF-CDF-v1.patch (9.7 KB) - added by rbeezer 10 years ago.
trac_13035-referee.patch (1.9 KB) - added by was 10 years ago.
referee patch

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by rbeezer

comment:1 Changed 10 years ago by rbeezer

  • Authors set to Rob Beezer
  • Cc ddrake added
  • Keywords sd40.5 added
  • Status changed from new to needs_review

Changed 10 years ago by was

referee patch

comment:2 Changed 10 years ago by was

Positive review subject to referee patch being accepted.

comment:3 Changed 10 years ago by rbeezer

  • Reviewers set to William Stein
  • Status changed from needs_review to positive_review

I appreciate the referee patch being contributed. Looks good, so positive review overall.

comment:4 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.1.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.