Opened 10 years ago
Last modified 10 years ago
#13018 closed enhancement
Positive definite check for exact matrices — at Version 8
Reported by: | rbeezer | Owned by: | jason, was |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.1 |
Component: | linear algebra | Keywords: | sd40.5 |
Cc: | novoselt | Merged in: | |
Authors: | Rob Beezer | Reviewers: | Dan Drake |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #12966 | Stopgaps: |
Description (last modified by )
Implements an "is_positive_definite()" method for matrices over exact rings.
Apply:
Change History (9)
comment:1 Changed 10 years ago by
- Cc novoselt added
- Dependencies set to #12966
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 10 years ago by
- Keywords sd40.5 added
comment:3 Changed 10 years ago by
- Reviewers set to Dan Drake
Changed 10 years ago by
comment:4 Changed 10 years ago by
- Description modified (diff)
Thanks, Dan. Standalone "v2" patch fixes the grammar. For matrices that are positive definite the doctest now includes the (positive) determinants of the leading principal submatrices. For those that are not positive definite there is an example vector violating the defining condition (which was a great suggestion).
comment:5 Changed 10 years ago by
Apply only trac_13018-is-positive-definite-v2.patch
comment:6 Changed 10 years ago by
Somehow this ticket is already marked as "positive review" on the wiki page. Dan - do you agree with the verdict?
comment:7 Changed 10 years ago by
- Status changed from needs_review to positive_review
Yes. I was just trying to set it to positive review. :)
comment:8 Changed 10 years ago by
- Description modified (diff)
This looks good. Several comments:
True
if the matrix is square, symmetric or Hermitian, and meeting the condition..." should be "and meets the condition...".
v^T * M * v
is negative.