Opened 10 years ago

Closed 8 years ago

#13008 closed enhancement (fixed)

refactor squarefree_decomposition to allow different rings to chose different implementations

Reported by: saraedum Owned by: AlexGhitza
Priority: minor Milestone: sage-6.3
Component: algebra Keywords: polynomial, squarefree, sd59
Cc: Merged in:
Authors: Julian Rueth Reviewers: Martin Albrecht
Report Upstream: N/A Work issues:
Branch: 29264c6 (Commits, GitHub, GitLab) Commit: 29264c639511608c3b14e7003fdb0e13b1a32875
Dependencies: #12404, #13048 Stopgaps:

Status badges

Description (last modified by saraedum)

Refactor squarefree_decomposition() of univariate polynomials to call _squarefree_decomposition_univariate() of the base ring. This makes it easier to have different algorithms in different rings.

This will make it easier to implement square-free decomposition over perfect fields and separably generated extensions of perfect fields.

Also, the implemented algorithms only work for some base fields. The checks are now more specific.

Change History (8)

comment:1 Changed 10 years ago by saraedum

  • Dependencies changed from #12404 to #12404, #13048

comment:2 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:3 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:4 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:5 Changed 8 years ago by saraedum

  • Branch set to u/saraedum/ticket/13008
  • Created changed from 05/25/12 12:09:52 to 05/25/12 12:09:52
  • Modified changed from 05/06/14 15:20:58 to 05/06/14 15:20:58

comment:6 Changed 8 years ago by saraedum

  • Authors set to Julian Rueth
  • Description modified (diff)
  • Keywords sd59 added
  • Status changed from new to needs_review

comment:7 Changed 8 years ago by malb

  • Commit set to 29264c639511608c3b14e7003fdb0e13b1a32875
  • Reviewers set to Martin Albrecht
  • Status changed from needs_review to positive_review

Looks good & we discussed the design decision.

New commits:

​29264c6Refactor squarefree_decomposition of polynomials

comment:8 Changed 8 years ago by vbraun

  • Branch changed from u/saraedum/ticket/13008 to 29264c639511608c3b14e7003fdb0e13b1a32875
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.