Opened 10 years ago
Closed 9 years ago
#13004 closed defect (fixed)
make micro_release doesn't work
Reported by: | was | Owned by: | GeorgSWeber |
---|---|---|---|
Priority: | major | Milestone: | sage-5.10 |
Component: | build | Keywords: | |
Cc: | Merged in: | sage-5.10.beta3 | |
Authors: | Volker Braun | Reviewers: | Marc Mezzarobba |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
wstein@sage:/scratch/wstein/may/sage-5.0.rc1$ make micro_release bash -c ". spkg/bin/sage-env && local/bin/sage-micro_release" Stripping .so files in local/lib strip "/scratch/wstein/may/sage-5.0.rc1/local/lib/libzn_poly.so" ... strip "/scratch/wstein/may/sage-5.0.rc1/local/lib/libpython2.7.so" bash: line 1: 31544 Segmentation fault local/bin/sage-micro_release make: *** [micro_release] Error 139 wstein@sage:/scratch/wstein/may/sage-5.0.rc1$
Attachments (1)
Change History (9)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
The attached patch splits sage-micro_release into a shell script that does the stripping and a python script that does all the rest.
comment:3 Changed 9 years ago by
- Status changed from new to needs_review
Why isn't this ticket flagged need_review?
comment:4 Changed 9 years ago by
- Reviewers set to Marc Mezzarobba
- Status changed from needs_review to positive_review
Anyway, the patch looks reasonable and works for me, so I took the liberty to give it positive_review. I hope this is acceptable.
(Apply to local/bin
.)
comment:5 Changed 9 years ago by
- Status changed from positive_review to needs_work
Would it not be a good idea to limit the stripping to files which are executable?
find "$SAGE_LOCAL/bin" "$SAGE_LOCAL/lib" -type f -executable -exec strip '{}' ';'
comment:6 Changed 9 years ago by
- Status changed from needs_work to positive_review
You can also strip static libraries (.a
) and those should not be executable.
comment:7 Changed 9 years ago by
I guess #11743 becomes a duplicate.
comment:8 Changed 9 years ago by
- Merged in set to sage-5.10.beta3
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Oops -- stripping python from a python script!?