Opened 9 years ago
Closed 9 years ago
#12999 closed defect (fixed)
Color('red') > Color('red') returns True
Reported by: | kcrisman | Owned by: | jason, was |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.1 |
Component: | graphics | Keywords: | sd40.5 |
Cc: | Merged in: | sage-5.1.beta4 | |
Authors: | Keshav Kini | Reviewers: | Karl-Dieter Crisman |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #11383 | Stopgaps: |
Description (last modified by )
sage: Color('red') > Color('red') True sage: Color('red') > Color('yellow') True
This seems weird. Especially in view of #11383 (to which this is a followup), maybe these should all be False
.
Apply trac_12999-invalidate-order-comparisons-Color.patch and trac_12999-allow-ge-le.patch.
Attachments (2)
Change History (9)
Changed 9 years ago by
comment:1 Changed 9 years ago by
- Dependencies set to #11383
- Status changed from new to needs_review
How's this?
comment:2 Changed 9 years ago by
- Reviewers set to Karl-Dieter Crisman
- Status changed from needs_review to needs_work
As discussed, 3<=3
so the same should be true for colors.
comment:3 Changed 9 years ago by
That's a rather strange looking emoticon... :)
comment:4 Changed 9 years ago by
- Status changed from needs_work to needs_review
Your wish is my command!
patchbot: apply trac_12999-invalidate-order-comparisons-Color.patch trac-12999-allow-ge-le.patch
comment:5 Changed 9 years ago by
Hm, didn't seem to work - let's try again
patchbot: apply trac_12999-invalidate-order-comparisons-Color.patch trac_12999-allow-ge-le.patch
comment:6 Changed 9 years ago by
- Description modified (diff)
- Status changed from needs_review to positive_review
This looks good.
comment:7 Changed 9 years ago by
- Merged in set to sage-5.1.beta4
- Resolution set to fixed
- Status changed from positive_review to closed
apply to $SAGE_ROOT/devel/sage