Opened 9 years ago

Closed 9 years ago

#12999 closed defect (fixed)

Color('red') > Color('red') returns True

Reported by: kcrisman Owned by: jason, was
Priority: minor Milestone: sage-5.1
Component: graphics Keywords: sd40.5
Cc: Merged in: sage-5.1.beta4
Authors: Keshav Kini Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #11383 Stopgaps:

Status badges

Description (last modified by kcrisman)

sage: Color('red') > Color('red')
True
sage: Color('red') > Color('yellow')
True

This seems weird. Especially in view of #11383 (to which this is a followup), maybe these should all be False.


Apply trac_12999-invalidate-order-comparisons-Color.patch and trac_12999-allow-ge-le.patch.

Attachments (2)

trac_12999-invalidate-order-comparisons-Color.patch (3.0 KB) - added by kini 9 years ago.
apply to $SAGE_ROOT/devel/sage
trac_12999-allow-ge-le.patch (1.9 KB) - added by kini 9 years ago.
apply to $SAGE_ROOT/devel/sage

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by kini

apply to $SAGE_ROOT/devel/sage

comment:1 Changed 9 years ago by kini

  • Authors set to Keshav Kini
  • Dependencies set to #11383
  • Status changed from new to needs_review

How's this?

comment:2 Changed 9 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_review to needs_work

As discussed, 3<=3 so the same should be true for colors.

comment:3 Changed 9 years ago by kini

That's a rather strange looking emoticon... :)

Changed 9 years ago by kini

apply to $SAGE_ROOT/devel/sage

comment:4 Changed 9 years ago by kini

  • Status changed from needs_work to needs_review

Your wish is my command!

patchbot: apply trac_12999-invalidate-order-comparisons-Color.patch trac-12999-allow-ge-le.patch

comment:5 Changed 9 years ago by kini

Hm, didn't seem to work - let's try again

patchbot: apply trac_12999-invalidate-order-comparisons-Color.patch trac_12999-allow-ge-le.patch

comment:6 Changed 9 years ago by kcrisman

  • Description modified (diff)
  • Status changed from needs_review to positive_review

This looks good.

comment:7 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.1.beta4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.