Opened 8 years ago

Closed 7 years ago

#12983 closed defect (fixed)

Fix LiE optional SPKG

Reported by: kini Owned by: tbd
Priority: major Milestone: sage-5.1
Component: packages: optional Keywords: sd40.5
Cc: ohanar Merged in:
Authors: Keshav Kini Reviewers: R. Andrew Ohana
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

This SPKG is a disaster - uncommitted changes, untracked files, no .hgignore, SPKG.txt not containing any of the required information, patches that are actually full files to be copied, src/ directory that has already been halfway patched, dependency on bison not mentioned anywhere, package is built in-place in $SAGE_LOCAL/lib and left there with all sources, Solaris-specific makefile is not copied due to typo in pathname...

spkg: http://boxen.math.washington.edu/home/keshav/files/lie-2.2.2.p4.spkg

Change History (10)

comment:1 Changed 8 years ago by dimpase

feel free to unify this with #8151 and close the latter...

comment:2 Changed 7 years ago by kini

  • Description modified (diff)

Cool, even the upstream source is screwed up...

Will do.

comment:3 Changed 7 years ago by kini

  • Authors set to Keshav Kini
  • Cc ohanar added
  • Status changed from new to needs_review

Well, here's an SPKG: http://boxen.math.washington.edu/home/keshav/files/lie-2.2.2.p4.spkg

Questions: should the files really be put in $SAGE_LOCAL/lib/LiE? They are not exactly libraries. But they are not exactly "architecture-independent" (since they contain binaries), so the FHS says they shouldn't go in $SAGE_LOCAL/share/LiE either. Or should I try to strip all the source and put the resulting stuff in $SAGE_LOCAL/bin/LiE? That seems like maybe the most reasonable option, but then I need to figure out which files are unnecessary for the final binary.

comment:4 Changed 7 years ago by kini

  • Keywords sd40.5 added

comment:5 Changed 7 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 7 years ago by ohanar

  • Status changed from needs_review to positive_review

Looks fine and compiles fine on clang.

comment:7 Changed 7 years ago by jdemeyer

Please fill in your real name in the Author / Reviewer fields.

comment:8 Changed 7 years ago by kini

  • Reviewers set to R. Andrew Ohana

Done

comment:9 Changed 7 years ago by schilly

spkg on the server now

comment:10 Changed 7 years ago by jdemeyer

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.