Opened 9 years ago
Closed 9 years ago
#12981 closed enhancement (fixed)
Ljubljana Graph
Reported by: | ncohen | Owned by: | jason, ncohen, rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-5.1 |
Component: | graph theory | Keywords: | sd40.5 |
Cc: | wdj, kini, dimpase | Merged in: | sage-5.1.beta4 |
Authors: | Nathann Cohen | Reviewers: | Keshav Kini |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #12942, #12945, #12952, #12971, #12980 | Stopgaps: |
Description
Yeahhhhhhh !! For this one I found a pretty embedding ! :-)
Nathann
Attachments (2)
Change History (7)
Changed 9 years ago by
comment:1 Changed 9 years ago by
- Status changed from new to needs_review
Changed 9 years ago by
comment:2 Changed 9 years ago by
- Keywords sd40.5 added
- Reviewers set to Keshav Kini
Here is a review patch! This time I see you have already added "Graph" to the function name :) I fixed a typo in the docstring, made the function microscopically faster, and removed an unreachable return statement.
If you agree with the review patch, we can set this to positive review.
patchbot: apply trac_12981.patch trac_12981.reviewer.patch
comment:3 Changed 9 years ago by
- Status changed from needs_review to positive_review
I regret that you removed my i+=0
, for it is always useful to add these statements at random places in the code. Otherwise, thank you again for this review :-)
Nathann
comment:4 Changed 9 years ago by
:)
comment:5 Changed 9 years ago by
- Merged in set to sage-5.1.beta4
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
apply to $SAGE_ROOT/devel/sage