Opened 10 years ago

Closed 10 years ago

#12980 closed enhancement (fixed)

Harries-Wong graph

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.1
Component: graph theory Keywords: sd40.5
Cc: kini, wdj Merged in: sage-5.1.beta4
Authors: Nathann Cohen Reviewers: Keshav Kini
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12942, #12945, #12952, #12971 Stopgaps:

Status badges

Description

The Harries-Wong graph among our graph generators. With an ugly embedding, that at least say something about the orbits...

God, finding good drawings is really tough ;-)

Nathann

Attachments (2)

trac_12980.patch​ (6.7 KB) - added by ncohen 10 years ago.
trac_12980.reviewer.patch​ (10.3 KB) - added by kini 10 years ago.
apply to $SAGE_ROOT/devel/sage

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by ncohen

comment:1 Changed 10 years ago by ncohen

  • Status changed from new to needs_review

Changed 10 years ago by kini

apply to $SAGE_ROOT/devel/sage

comment:2 Changed 10 years ago by kini

  • Keywords sd40.5 added
  • Reviewers set to Keshav Kini

Here is a review patch! If you agree with it, then we can change this ticket to positive review.

Other than reformatting, I added the word "Graph" to the method name, as in the case of the Biggs-Smith graph. I also edited the docstring a bit for language, and modified the _line_embedding function to be a bit faster.

comment:3 Changed 10 years ago by kini

patchbot: apply trac_12980.patch trac_12980.reviewer.patch

comment:4 Changed 10 years ago by ncohen

  • Status changed from needs_review to positive_review

+1 too !

Nathann

comment:5 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.1.beta4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.