Changes between Version 5 and Version 9 of Ticket #12974


Ignore:
Timestamp:
05/25/12 18:36:18 (9 years ago)
Author:
ppurka
Comment:

Sorry for the mixup of the whitespace and refactoring patches - I wasn't thinking clearly. I have uploaded the new patches. The whitespace one is completely on its own now. The patches are

  1. trac_12974-fix_graphics_attributes.patch - makes the change . to ._
  2. trac_12974-refactor.patch - refactoring the tick formatter in Graphics.matplotlib
  3. trac_12974-reorder_some_arguments.patch - does the reordering of the arguments in the dicts. matplotlib is untouched now.
  4. trac_12974-whitespace_cleanup.patch - does the whitespace cleanup via the sed function mentioned in comment:4

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12974 – Description

    v5 v9  
    11The first patch makes all the `.__attribute` into `._attribute` so that the `Graphics` class can be inherited in the future. This is desirable since all the important functions are present in this class. One will not lose anything in terms of existing functionality.
    22
    3 The second patch does more cleanups, whitespace removal, and refactoring of one big bunch of code which is present twice in `Graphics().matplotlib()`.
     3The second patch does refactoring of one big bunch of code which is present twice in `Graphics().matplotlib()`.
     4
     5The third and fourth patches are more of a 'cleanup' nature.
    46
    57Passes all doctests in `devel/sage/sage/plot`. (The patches are created using 5.0-rc0)
    68----
    79Apply patches in this order to `devel/sage`:
    8 1. [attachment:trac_12974-fix_graphics_attributes.patch]
    9 2. [attachment:trac_12974-refactor_and_whitespace_cleanups.patch]
    10 Apply this third patch if the reordering now is satisfactory
    11 3. [attachment:trac_12974-reorder_some_arguments.patch]
     101. [attachment:trac_12974-fix_graphics_attributes.patch] - makes the change .__ to ._
     112. [attachment:trac_12974-refactor.patch] - refactoring the tick formatter in Graphics.matplotlib
     123. [attachment:trac_12974-reorder_some_arguments.patch] - does the reordering of some arguments
     134. [attachment:trac_12974-whitespace_cleanup.patch] - cleans up trailing whitespace via the sed function mentioned in comment:4