Changes between Version 1 and Version 4 of Ticket #12974


Ignore:
Timestamp:
05/25/12 10:02:09 (9 years ago)
Author:
ppurka
Comment:
  1. I added the new file, where I don't reorder the arguments. Also, I ran the following sed expression (in zsh) to cleanup trailing whitespaces from sage/plot
    ....rc0/devel/sage/sage/plot» for i in **/*.py; do
     sed -i -e 's/[[:space:]]\+$//' "$i";
    done
    
  1. I removed the backslash and replaced it with simple brackets
  2. I had also doctested the new matplotlib function, but it seems that went into the log plot code. Sorry for the mixup. The updated patch (the second patch) contains the doctest now.
  3. From the doctests in #4529, I found that there were other functions outside of sage/plot that were using attributes of Graphics as _Graphics__object, etc. All these are fixed now (in the first patch).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12974

    • Property Status changed from needs_review to needs_work
    • Property Reviewers changed from to Karl-Dieter Crisman
    • Property Keywords sd40.5 added
    • Property Authors changed from to Punarbasu Purkayastha
  • Ticket #12974 – Description

    v1 v4  
    66----
    77Apply patches in this order to `devel/sage`:
    8 1. [attachment:trac_12974-fix_graphics_attributes_and_reorder_args.patch]
     81. [attachment:trac_12974-fix_graphics_attributes.patch]
    992. [attachment:trac_12974-refactor_and_whitespace_cleanups.patch]