Opened 10 years ago
Closed 10 years ago
#12972 closed defect (fixed)
Fix small bug in elliptic curve saturation
| Reported by: | John Cremona | Owned by: | John Cremona |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.4 |
| Component: | elliptic curves | Keywords: | saturation |
| Cc: | Merged in: | sage-5.4.beta1 | |
| Authors: | John Cremona | Reviewers: | Volker Braun |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description
The saturation() method for elliptic curves of Q has a small bug: a variable (which will most often notbe used) was not initialised. At the same time I changed two parameter in the saturation code.
Attachments (1)
Change History (7)
Changed 10 years ago by
| Attachment: | Qsat.patch added |
|---|
comment:1 Changed 10 years ago by
| Status: | new → needs_review |
|---|
I have been using this code (with the patch) for many thousands of curves over several months. I no longer remember which curve actually triggered the bug, so I have not added a doctest. WIth a new release I realised that I had never submitted the patch for review (but I will go on using it every day even if reviewers don't like the lack of doctest!).
comment:3 Changed 10 years ago by
| Reviewers: | → Volker Braun |
|---|---|
| Status: | needs_review → positive_review |
comment:5 Changed 10 years ago by
| Milestone: | sage-5.3 → sage-5.4 |
|---|
comment:6 Changed 10 years ago by
| Merged in: | → sage-5.4.beta1 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Applies t.o 5.0