Opened 6 years ago

Last modified 22 months ago

#12955 needs_work enhancement

Move __len__ and __getitem__ from Parent to FiniteEnumeratedSets

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-6.9
Component: categories Keywords:
Cc: sage-combinat, ncohen Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: public/12955 (Commits) Commit: b6aeeb300a5c658a97a981c0a353806ae37bf446
Dependencies: #12957 Stopgaps:

Description (last modified by vdelecroix)

Title says it all. The point is that with the current implementation prevents categories to override those methods with something more interesting. Alas, the attached patch is not yet ready for consumption since there still remains finite (enumerated) sets in Sage that are not in FiniteSets of FiniteEnumeratedSets (see #12913 and #12957)

In the mean time, #12956 provides a workaround for __getitem__.

Attachments (1)

trac_12955-move_getitem_len_out_of_parent-nt.patch​ (4.5 KB) - added by nthiery 6 years ago.
Preliminary patch

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by nthiery

Preliminary patch

comment:1 Changed 6 years ago by nthiery

  • Dependencies set to #12957
  • Description modified (diff)

comment:2 Changed 5 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:3 Changed 4 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:4 Changed 4 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:5 Changed 4 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:6 Changed 3 years ago by vdelecroix

Is there any concrete plan for this 3 year old ticket?

comment:7 Changed 3 years ago by ncohen

  • Cc ncohen added

comment:8 Changed 3 years ago by vdelecroix

  • Description modified (diff)

comment:9 Changed 3 years ago by vdelecroix

  • Authors Nicolas M. Thiéry deleted
  • Branch set to public/12955
  • Commit set to b6aeeb300a5c658a97a981c0a353806ae37bf446
  • Keywords days38 removed
  • Milestone changed from sage-6.4 to sage-6.9
  • Status changed from new to needs_review

Let the patchbot runs to see the amount of work...

New commits:

​66d60d2#12955: Move __len__ and __getitem__ from Parent to FiniteEnumeratedSets
​b6aeeb3Trac 12955: fix polynomial ring creation via R['x']

comment:10 Changed 3 years ago by vdelecroix

  • Status changed from needs_review to needs_work

... a lot!

comment:11 Changed 22 months ago by klee

Please check #20902, related to this ticket.

Note: See TracTickets for help on using tickets.