Opened 7 years ago

Closed 5 years ago

#12938 closed defect (wontfix)

several spkg's don't install if the .hg repos have been deleted

Reported by: was Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: distribution Keywords: sd40.5
Cc: Merged in:
Authors: William Stein, Keshav Kini Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

For security *and* size purposes, some people delete all the .hg repos from Sage. This breaks installing precisely four of them: extcode, sage, sage_root, sage_scripts. This ticket fixes all these.

Attachments (4)

trac_12938-sage.patch​ (617 bytes) - added by was 7 years ago.
apply to the Sage library (in SAGE_ROOT/devel/sage/)
trac_12938-extcode.patch​ (564 bytes) - added by kini 7 years ago.
apply to $SAGE_ROOT/data/extcode
trac_12938-scripts.patch​ (644 bytes) - added by kini 7 years ago.
apply to $SAGE_LOCAL/bin
trac_12938-root.patch​ (665 bytes) - added by kini 7 years ago.
apply to $SAGE_ROOT

Download all attachments as: .zip

Change History (19)

Changed 7 years ago by was

apply to the Sage library (in SAGE_ROOT/devel/sage/)

Changed 7 years ago by kini

apply to $SAGE_ROOT/data/extcode

Changed 7 years ago by kini

apply to $SAGE_LOCAL/bin

Changed 7 years ago by kini

apply to $SAGE_ROOT

comment:1 Changed 7 years ago by kini

  • Authors changed from William Stein to William Stein, Keshav Kini
  • Keywords sd40.5 added
  • Status changed from new to needs_review

I guess this should fix everything...

comment:2 Changed 7 years ago by was

  • Reviewers set to William Stein

comment:3 Changed 7 years ago by was

I'm testing this on sage.math by build/testing from scratch with the four .hg repos mentioned above deleted.

comment:4 Changed 7 years ago by was

The sage_scripts part fails: 

gcc version 4.6.3 (GCC) 
****************************************************
./spkg-install: line 24: /scratch/wstein/ref/sage-5.0/local/bin//.hg/hgrc: No such file or directory

That this won't work is obvious if you look at spkg-install.

comment:5 Changed 7 years ago by was

  • Status changed from needs_review to needs_work

comment:6 follow-up: Changed 7 years ago by kini

I don't really understand what you did. To make this work you will need to do sage -sdist first, then build from that. At what point are the .hg repos deleted?

comment:7 in reply to: ↑ 6 Changed 7 years ago by was

Replying to kini:

I don't really understand what you did.

  1. Extra sage-5.0.tar
  2. tar xf something.spkg
  3. Apply your patch(es)
  4. Delete .hg directory
  5. sage -pkg something
  6. make

comment:8 Changed 7 years ago by kini

OK, so please instead try this:

  1. Have a Sage installation
  2. Apply my patches (and your patch) to the repos in the installation of Sage
  3. Run sage --sdist
  4. Unpack the resulting sage-whatever.tar
  5. Go to spkg/standard
  6. tar xf the four SPKGs
  7. Delete .hg directory
  8. sage -pkg the four SPKGs
  9. make in the root of the extracted Sage source distro

comment:9 Changed 7 years ago by kini

Yeah, this needs more work. There is a ton of usage of hg throughout the scripts. Big mess.

comment:10 Changed 7 years ago by ohanar

the extcode spkg should be fixed in #13123.

comment:11 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:12 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:13 Changed 5 years ago by chapoton

  • Milestone changed from sage-6.2 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to needs_review

This seems to be a mercurially dead ticket, now that we have switched to git.

comment:14 Changed 5 years ago by mmezzarobba

  • Reviewers changed from William Stein to Marc Mezzarobba
  • Status changed from needs_review to positive_review

comment:15 Changed 5 years ago by vbraun

  • Resolution set to wontfix
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.