Opened 7 years ago
Closed 6 years ago
#12938 closed defect (wontfix)
several spkg's don't install if the .hg repos have been deleted
Reported by: | was | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | distribution | Keywords: | sd40.5 |
Cc: | Merged in: | ||
Authors: | William Stein, Keshav Kini | Reviewers: | Marc Mezzarobba |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
For security *and* size purposes, some people delete all the .hg repos from Sage. This breaks installing precisely four of them: extcode, sage, sage_root, sage_scripts. This ticket fixes all these.
Attachments (4)
Change History (19)
Changed 7 years ago by
comment:1 Changed 7 years ago by
- Keywords sd40.5 added
- Status changed from new to needs_review
I guess this should fix everything...
comment:2 Changed 7 years ago by
- Reviewers set to William Stein
comment:3 Changed 7 years ago by
I'm testing this on sage.math by build/testing from scratch with the four .hg repos mentioned above deleted.
comment:4 Changed 7 years ago by
The sage_scripts part fails:
gcc version 4.6.3 (GCC) **************************************************** ./spkg-install: line 24: /scratch/wstein/ref/sage-5.0/local/bin//.hg/hgrc: No such file or directory
That this won't work is obvious if you look at spkg-install.
comment:5 Changed 7 years ago by
- Status changed from needs_review to needs_work
comment:6 follow-up: ↓ 7 Changed 7 years ago by
I don't really understand what you did. To make this work you will need to do sage -sdist
first, then build from that. At what point are the .hg repos deleted?
comment:7 in reply to: ↑ 6 Changed 7 years ago by
Replying to kini:
I don't really understand what you did.
- Extra sage-5.0.tar
- tar xf something.spkg
- Apply your patch(es)
- Delete .hg directory
- sage -pkg something
- make
comment:8 Changed 7 years ago by
OK, so please instead try this:
- Have a Sage installation
- Apply my patches (and your patch) to the repos in the installation of Sage
- Run
sage --sdist
- Unpack the resulting
sage-whatever.tar
- Go to
spkg/standard
tar xf
the four SPKGs- Delete
.hg
directory sage -pkg
the four SPKGsmake
in the root of the extracted Sage source distro
comment:9 Changed 7 years ago by
Yeah, this needs more work. There is a ton of usage of hg throughout the scripts. Big mess.
comment:10 Changed 7 years ago by
the extcode spkg should be fixed in #13123.
comment:11 Changed 6 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:12 Changed 6 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:13 Changed 6 years ago by
- Milestone changed from sage-6.2 to sage-duplicate/invalid/wontfix
- Status changed from needs_work to needs_review
This seems to be a mercurially dead ticket, now that we have switched to git.
comment:14 Changed 6 years ago by
- Reviewers changed from William Stein to Marc Mezzarobba
- Status changed from needs_review to positive_review
comment:15 Changed 6 years ago by
- Resolution set to wontfix
- Status changed from positive_review to closed
apply to the Sage library (in SAGE_ROOT/devel/sage/)