Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#12937 closed defect (fixed)

sqlite sometimes picks up the wrong libraries (e.g., readline) since we forgot to set LDFLAGS

Reported by: was Owned by: tbd
Priority: major Milestone: sage-5.1
Component: packages: standard Keywords:
Cc: Merged in: sage-5.1.beta1
Authors: William Stein Reviewers: John Connor
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by was)

On certain systems, e.g., Fedora with libreadline.so.5 systemwide, when building sqlite, the sqlite3 binary points to libreadline.so.5. However, Sage ships libreadline.so.6. The fix is trivial -- just define LDFLAGS, as we always should do. (Why we don't in ./install is beyond me...)

​http://wstein.org/patches/sqlite-3.7.5.p1.spkg

Attachments (1)

sqlite-3.7.5.p1.diff​ (1.4 KB) - added by jdemeyer 7 years ago.
Diff for the sqlite spkg. For reference / review only.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by was

  • Authors set to William Stein
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 8 years ago by JohnConnor

  • Reviewers set to John Connor
  • Status changed from needs_review to positive_review

comment:3 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.1.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed

Changed 7 years ago by jdemeyer

Diff for the sqlite spkg. For reference / review only.

comment:4 Changed 7 years ago by jdemeyer

Obviously, -I $SAGE_LOCAL/lib should be -L $SAGE_LOCAL/lib. This couldn't have solved any problem.

comment:5 Changed 7 years ago by jdemeyer

Finally fixing this properly in #14629.

Note: See TracTickets for help on using tickets.