Opened 11 years ago

Closed 10 years ago

## #12917 closed enhancement (fixed)

# is_cartesian_product

Reported by: | Nathann Cohen | Owned by: | tbd |
---|---|---|---|

Priority: | major | Milestone: | sage-5.2 |

Component: | graph theory | Keywords: | |

Cc: | David Joyner, Dima Pasechnik, Rob Beezer | Merged in: | sage-5.2.beta0 |

Authors: | Nathann Cohen | Reviewers: | David Coudert |

Report Upstream: | N/A | Work issues: | |

Branch: | Commit: | ||

Dependencies: | Stopgaps: |

### Description

This patch implements a new method that lets one recognize whether a graph can be written as the cartesian products of some others. A new module is created because the documentation is rather long, and because the first aim was to write the method much more efficiently, at a much lower level.

As usual, the patch would be much harder to review if it were done all at once, and we would need two versions anyway to check the correction of the trickier algorithm.

The aim of this patch is also to obtain better plots of very symmetrical graphs.

Nathann

### Attachments (1)

### Change History (10)

### comment:1 Changed 11 years ago by

Component: | PLEASE CHANGE → graph theory |
---|---|

Status: | new → needs_review |

Type: | PLEASE CHANGE → enhancement |

### comment:2 Changed 10 years ago by

Reviewers: | → David Coudert |
---|---|

Status: | needs_review → needs_work |

### comment:3 Changed 10 years ago by

Status: | needs_work → needs_review |
---|

Updated ! It probably needed a rebase after your patch on graph products got merged ! `;-)`

Nathann

### comment:4 Changed 10 years ago by

Status: | needs_review → positive_review |
---|

The patch is working perfectly (install, tests, functionality, docbuild and display). Nice work!

In another patch, one should do the same for digraphs.

### comment:5 Changed 10 years ago by

Wouhouuuuuuuu !! Thanks !

I am not sure the algorith would work for digraphs though.. Or it is probably easier, I do not know `:-)`

Nathann

### comment:7 Changed 10 years ago by

Authors: | → Nathann Cohen |
---|

### comment:8 Changed 10 years ago by

Milestone: | sage-5.1 → sage-5.2 |
---|

### comment:9 Changed 10 years ago by

Merged in: | → sage-5.2.beta0 |
---|---|

Resolution: | → fixed |

Status: | positive_review → closed |

**Note:**See TracTickets for help on using tickets.

Hello,

I'm unable to install the patch with sage.5.1.beta1.