Opened 7 years ago
Closed 7 years ago
#12917 closed enhancement (fixed)
is_cartesian_product
Reported by: | ncohen | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-5.2 |
Component: | graph theory | Keywords: | |
Cc: | wdj, dimpase, rbeezer | Merged in: | sage-5.2.beta0 |
Authors: | Nathann Cohen | Reviewers: | David Coudert |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This patch implements a new method that lets one recognize whether a graph can be written as the cartesian products of some others. A new module is created because the documentation is rather long, and because the first aim was to write the method much more efficiently, at a much lower level.
As usual, the patch would be much harder to review if it were done all at once, and we would need two versions anyway to check the correction of the trickier algorithm.
The aim of this patch is also to obtain better plots of very symmetrical graphs.
Nathann
Attachments (1)
Change History (10)
comment:1 Changed 7 years ago by
- Component changed from PLEASE CHANGE to graph theory
- Status changed from new to needs_review
- Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 7 years ago by
- Reviewers set to David Coudert
- Status changed from needs_review to needs_work
comment:3 Changed 7 years ago by
- Status changed from needs_work to needs_review
Updated ! It probably needed a rebase after your patch on graph products got merged ! ;-)
Nathann
comment:4 Changed 7 years ago by
- Status changed from needs_review to positive_review
The patch is working perfectly (install, tests, functionality, docbuild and display). Nice work!
In another patch, one should do the same for digraphs.
comment:5 Changed 7 years ago by
Wouhouuuuuuuu !! Thanks !
I am not sure the algorith would work for digraphs though.. Or it is probably easier, I do not know :-)
Nathann
comment:6 Changed 7 years ago by
Please fill in your real name in the Author / Reviewer fields.
comment:7 Changed 7 years ago by
comment:8 Changed 7 years ago by
- Milestone changed from sage-5.1 to sage-5.2
comment:9 Changed 7 years ago by
- Merged in set to sage-5.2.beta0
- Resolution set to fixed
- Status changed from positive_review to closed
Hello,
I'm unable to install the patch with sage.5.1.beta1.