Opened 11 years ago
Last modified 9 years ago
#12900 closed enhancement
(Demazure) roots of toric varieties — at Version 9
Reported by: | Volker Braun | Owned by: | Alex Ghitza |
---|---|---|---|
Priority: | major | Milestone: | sage-5.12 |
Component: | algebraic geometry | Keywords: | |
Cc: | Andrey Novoseltsev | Merged in: | |
Authors: | Volker Braun | Reviewers: | Andrey Novoseltsev, Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #13023 | Stopgaps: |
Description (last modified by )
The Demazure roots (often just called roots) of a toric variety give you the non-Abelian part of the continuous automorphisms.
Apply
Change History (9)
comment:1 Changed 11 years ago by
Cc: | Andrey Novoseltsev added |
---|---|
Dependencies: | → #12892 |
Status: | new → needs_review |
comment:2 Changed 11 years ago by
Reviewers: | → Andrey Novoseltsev |
---|
Should there perhaps be a check that the variety is complete? Also would be nice to have a direct link to arXiv.
comment:3 Changed 11 years ago by
For incomplete varieties it would already bomb out because it can't enumerate the points in the (non-compact) dual polytope. But its better to have an explicit check with meaningful error message. Also fixed the typesetting of the doctest.
comment:4 Changed 11 years ago by
Dependencies: | #12892 → #12892, #13023 |
---|
I've updated the paths for #13023, and checked that all doctests pass.
comment:5 Changed 9 years ago by
looks good to me.
I propose to remove the dependency to #12892, which is not really needed.
If you agree, you can remove the dependency and set a positive review.
comment:6 Changed 9 years ago by
Dependencies: | #12892, #13023 → #13023 |
---|---|
Reviewers: | Andrey Novoseltsev → Andrey Novoseltsev, Frédéric Chapoton |
Status: | needs_review → positive_review |
I've rebased the original patch to get rid off fuzz.
comment:7 Changed 9 years ago by
Milestone: | sage-5.11 → sage-5.12 |
---|
comment:8 Changed 9 years ago by
Status: | positive_review → needs_info |
---|
Please clarify which patch(es) should be applied.
comment:9 Changed 9 years ago by
Description: | modified (diff) |
---|---|
Status: | needs_info → positive_review |
patchbot: apply trac_12900_Demazure_roots.patch, trac_12900_review.patch
Doesn't use anything from #12892, but otherwise this ticket applies with fuzz.