Opened 10 years ago

Closed 9 years ago

#12900 closed enhancement (fixed)

(Demazure) roots of toric varieties

Reported by: vbraun Owned by: AlexGhitza
Priority: major Milestone: sage-5.12
Component: algebraic geometry Keywords:
Cc: novoselt Merged in: sage-5.12.beta2
Authors: Volker Braun Reviewers: Andrey Novoseltsev, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #13023, #14891 Stopgaps:

Status badges

Description (last modified by vbraun)

The Demazure roots (often just called roots) of a toric variety give you the non-Abelian part of the continuous automorphisms.

Apply

Attachments (2)

trac_12900_review.patch (2.3 KB) - added by chapoton 9 years ago.
trac_12900_Demazure_roots.patch (4.1 KB) - added by vbraun 9 years ago.
Rebased patch

Download all attachments as: .zip

Change History (15)

comment:1 Changed 10 years ago by vbraun

  • Cc novoselt added
  • Dependencies set to #12892
  • Status changed from new to needs_review

Doesn't use anything from #12892, but otherwise this ticket applies with fuzz.

comment:2 Changed 10 years ago by novoselt

  • Reviewers set to Andrey Novoseltsev

Should there perhaps be a check that the variety is complete? Also would be nice to have a direct link to arXiv.

comment:3 Changed 10 years ago by vbraun

For incomplete varieties it would already bomb out because it can't enumerate the points in the (non-compact) dual polytope. But its better to have an explicit check with meaningful error message. Also fixed the typesetting of the doctest.

comment:4 Changed 10 years ago by vbraun

  • Dependencies changed from #12892 to #12892, #13023

I've updated the paths for #13023, and checked that all doctests pass.

comment:5 Changed 9 years ago by chapoton

looks good to me.

I propose to remove the dependency to #12892, which is not really needed.

If you agree, you can remove the dependency and set a positive review.

comment:6 Changed 9 years ago by vbraun

  • Dependencies changed from #12892, #13023 to #13023
  • Reviewers changed from Andrey Novoseltsev to Andrey Novoseltsev, Frédéric Chapoton
  • Status changed from needs_review to positive_review

I've rebased the original patch to get rid off fuzz.

comment:7 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:8 Changed 9 years ago by jdemeyer

  • Status changed from positive_review to needs_info

Please clarify which patch(es) should be applied.

comment:9 Changed 9 years ago by vbraun

  • Description modified (diff)
  • Status changed from needs_info to positive_review

patchbot: apply trac_12900_Demazure_roots.patch, trac_12900_review.patch

comment:10 Changed 9 years ago by jdemeyer

  • Status changed from positive_review to needs_work

This patch conflicts with #14891. One should be rebased on top of the other.

Changed 9 years ago by chapoton

comment:11 Changed 9 years ago by chapoton

  • Dependencies changed from #13023 to #13023, #14891

ok, I have made this ticket depend on #14891

I have rebased my review patch, but there remains a hunk in the original patch.

Changed 9 years ago by vbraun

Rebased patch

comment:12 Changed 9 years ago by vbraun

  • Status changed from needs_work to positive_review

Rebased.

comment:13 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.12.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.