Opened 10 years ago

Closed 10 years ago

#12897 closed enhancement (fixed)

Increase doctest coverage in coding/sd_codes.py to 100%

Reported by: Benjamin Jones Owned by: Minh Van Nguyen
Priority: minor Milestone: sage-5.1
Component: documentation Keywords: linear code doctest coverage
Cc: Merged in: sage-5.1.beta1
Authors: Benjamin Jones Reviewers: Punarbasu Purkayastha
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Benjamin Jones)

As the summary says. As of sage-5.0.beta12 we have:

sd_codes.py
SCORE sd_codes.py: 20% (1 of 5)

Missing documentation:
	 * MS(n):
	 * matA(n):
	 * matId(n):
	 * MS2(n):

Apply trac_12897_sd_codes_coverage.v2.patch to Sage library.

Attachments (1)

trac_12897_sd_codes_coverage.v2.patch (34.8 KB) - added by Benjamin Jones 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by Benjamin Jones

Status: newneeds_review

After the patch:

> sage -coverage sd_codes.py
----------------------------------------------------------------------
sd_codes.py
SCORE sd_codes.py: 100% (5 of 5)
----------------------------------------------------------------------

> sage -t --optional sd_codes.pysage -t --optional "devel/sage-test/sage/coding/sd_codes.py"
	 [3.0 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 3.0 seconds

comment:2 Changed 10 years ago by Benjamin Jones

Description: modified (diff)

comment:3 Changed 10 years ago by Punarbasu Purkayastha

I have just one comment:

In matA(n) and matId(n) it should be mentioned that the field is GF(2). Also, \delta_ij in matA should be \delta_{ij}.

Other than that, the patch looks good to me.

comment:4 Changed 10 years ago by Benjamin Jones

Description: modified (diff)

comment:5 Changed 10 years ago by Benjamin Jones

Ok, good point. The new patch has the changes.

comment:6 in reply to:  5 Changed 10 years ago by Punarbasu Purkayastha

Replying to benjaminfjones:

Ok, good point. The new patch has the changes.

I think you uploaded the older patch by mistake. :)

Changed 10 years ago by Benjamin Jones

comment:7 Changed 10 years ago by Benjamin Jones

Yes, sorry about that. It is the correct version now.

comment:8 Changed 10 years ago by Punarbasu Purkayastha

Reviewers: Punarbasu Purkayastha
Status: needs_reviewpositive_review

Thanks.

Looks good and passes all doctests in sage/coding (it shouldn't be affecting anything else anyway) in 5.0-beta12. Positive review from my side.

comment:9 Changed 10 years ago by Jeroen Demeyer

Merged in: sage-5.1.beta1
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.