Changes between Version 19 and Version 22 of Ticket #12876


Ignore:
Timestamp:
04/27/12 13:58:58 (8 years ago)
Author:
SimonKing
Comment:

With sage-5.0.beta13 plus #715, #11521, #12875, #12877, #12215 and trac_12876_category-fix_abstract_class-nt-rel11521.patch, all doc tests pass.

I made some additional cosmetic changes in a reviewer patch.

Further questions:

In sage/category/hecke_modules.py, you refer to ticket number ??? for fixing _test_zero and _test_elements. In sage/schemes/elliptic_curves/ell_curve_isogeny.py, you leave a reference to trac open as well. Have the tickets now been created? I didn't fix that yet.

I see that you rename Rings.HomCategory.ParentMethods.__new__ into __new__bx. Does that mean the ugly __new__ method ought to be removed (finally!)? But then, shouldn't __getnewargs__ be removed as well?

Please tell whether you want to address these questions in an additional patch. And I hope you agree with adding #715, #11521 and #12215 to the dependencies? Only #12215 needs review (hint...).

If you do agree, then put this to positive review, please.

Apply trac_12876_category-fix_abstract_class-nt-rel11521.patch trac_12876-reviewer.patch

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12876

    • Property Dependencies changed from #12875, #12877 to #715, #11521, #12875, #12877, #12215
  • Ticket #12876 – Description

    v19 v22  
    3030Apply:
    3131
    32  [attachment:trac_12876_category-fix_abstract_class-nt-rel11521.patch]
     32 * [attachment:trac_12876_category-fix_abstract_class-nt-rel11521.patch]
     33 * [attachment:trac_12876-reviewer.patch]