Changes between Version 5 and Version 19 of Ticket #12876


Ignore:
Timestamp:
04/27/12 08:01:55 (8 years ago)
Author:
SimonKing
Comment:

I have rebased your patch relative to #11521 (as I said: This already has positive review).

Please have a look whether you are happy with my changes: I only changed sage/categories/homset.py, by using the :trac: directive in two places, fixing one hunk that has only applied with fuzz and removing the import of Sets. Apart from that, I adopted your logic of constructing the homset.

So far, I have tested sage/categories/homset.py and have verified that the previously failing tests are indeed fixed by #11521 (in fact, I also had some other pathes applied, but I am convinced that ##11521 suffices). I am now running the full tests suite, with only #11521 (and its dependency #715) and the new patch (and its dependencies #12875 and #12877).

Apply trac_12876_category-fix_abstract_class-nt-rel11521.patch

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12876

    • Property Cc SimonKing added
    • Property Dependencies changed from to #12875, #12877
    • Property Work issues changed from to Fix ring_refcount_dict problem
  • Ticket #12876 – Description

    v5 v19  
    2727
    2828#11935 depends on this ticket
     29
     30Apply:
     31
     32 [attachment:trac_12876_category-fix_abstract_class-nt-rel11521.patch]