Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#12870 closed enhancement (fixed)

update optional package openssl to version 1.0.1a

Reported by: mariah Owned by: tbd
Priority: major Milestone: sage-5.1
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Mariah Lenox Reviewers: William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mariah)

Upgrade the optional package openssl to version 1.0.1a which was released on 19 April 2012.

Version with tarball removed:

spkg: http://wstein.org/home/wstein/patches/openssl-1.0.1a.spkg

Change History (12)

comment:1 Changed 7 years ago by mariah

  • Authors set to Mariah Lenox
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 7 years ago by was

Can you change the permissions:

wstein@sage:/scratch/wstein/ref/sage-5.0.beta15-boxen-x86_64-Linux$ wget  http://boxen.math.washington.edu/home/mariah/spkg/openssl-1.0.1a.spkg
--13:51:00--  http://boxen.math.washington.edu/home/mariah/spkg/openssl-1.0.1a.spkg
           => `openssl-1.0.1a.spkg'
Resolving boxen.math.washington.edu... 128.208.160.197
Connecting to boxen.math.washington.edu|128.208.160.197|:80... connected.
HTTP request sent, awaiting response... 403 Forbidden
13:51:00 ERROR 403: Forbidden.

comment:3 Changed 7 years ago by mariah

Done. Apologies.

comment:4 Changed 7 years ago by was

REPORT:

(this is long, but there is really only one trivial change I want made.)

  1. Delete this file -- why is it there?
    -rw-r-----  1 wstein wstein  21M 2012-04-19 05:20 openssl-1.0.1a.tar
    
  1. It builds fine on sage.math (64-bit ubuntu).
  1. It fails to build on OS X 10.7.3 after building sage-5.0.pre15 out of the box:
    gcc -I. -I.. -I../include  -fPIC -fno-common -DOPENSSL_PIC -DOPENSSL_THREADS -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -arch i386 -O3 -fomit-frame-pointer -DL_ENDIAN -DOPENSSL_BN_ASM_PART_WORDS -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DRMD160_ASM -DAE
    S_ASM -DVPAES_ASM -DWHIRLPOOL_ASM -DGHASH_ASM   -c -o mem_dbg.o mem_dbg.c
    gcc: error: i386: No such file or directory
    gcc: error: unrecognized option ‘-arch’
    gcc: error: i386: No such file or directory
    gcc: error: unrecognized option ‘-arch’
    make[1]: *** [cryptlib.o] Error 1
    make[1]: *** Waiting for unfinished jobs....
    make[1]: *** [mem.o] Error 1
    gcc: error: i386: No such file or directory
    gcc: error: unrecognized option ‘-arch’
    make[1]: *** [mem_dbg.o] Error 1
    make: *** [build_crypto] Error 1
    Error building openssl.
    
    real	0m3.738s
    user	0m2.527s
    sys	0m0.910s
    ************************************************************************
    Error installing package openssl-1.0.1a
    

This looks like some OS version detection code is wrong? Note gcc: error: unrecognized option ‘-arch’. Exactly the same problem happens with the openssl-1.0.0.p0 that we currently have in the optional package repo.

  1. On Ubuntu 64-bit (sage.math), I tried rebuilding Python after building the new openssl, and that worked fine and did include openssl support.
  1. I ran all doctests on ubuntu 64-bit and that worked fine. This isn't surprising, since I think no doctests use openssl.
  1. On OS X 10.6, I tried this:
    bsd:sage-5.0.beta8 wstein$ ./sage -i  http://boxen.math.washington.edu/home/mariah/spkg/openssl-1.0.1a.spkg
    

and it worked fine.

  1. It would be nice if there was an ".hgignore" file since
    $ hg status
    ? openssl-1.0.1a.spkg
    ? openssl-1.0.1a/SPKG.txt
    ? openssl-1.0.1a/openssl-1.0.1a.tar
    ? openssl-1.0.1a/src/ACKNOWLEDGMENTS
    ? openssl-1.0.1a/src/CHANGES
    ? openssl-1.0.1a/src/CHANGES.SSLeay
    ? openssl-1.0.1a/src/Configure
    ...
    

SUMMARY: The OS X 10.7.3 issue looks serious, but should not hold this back, because it is already in the current openssl optional package; it should be considered a new bug on a separate ticket. Otherwise, we just need to delete the upstream tarball which is there for no reason. Since this is an optional spkg, and we still don't officially support OS X 10.7.3, I don't consider this a total blocker for a positive review.

THUS: Positive review contingent on deleting that one tar file.

comment:5 Changed 7 years ago by was

  • Description modified (diff)
  • Status changed from needs_review to positive_review

comment:6 Changed 7 years ago by jdemeyer

  • Reviewers set to William Stein
  • Status changed from positive_review to needs_info

Which is the correct spkg?

comment:7 Changed 7 years ago by jdemeyer

*ping*

please clarify: why are there two spkg's listed?

comment:8 Changed 7 years ago by mariah

  • Description modified (diff)
  • Status changed from needs_info to needs_review

comment:9 Changed 7 years ago by mariah

  • Status changed from needs_review to positive_review

The spkg posted by William supercedes my spkg. (William's spkg removes a tar file that I mistakenly left in the spkg.)

I have removed my spkg from the Description.

I am setting this back to positive review because William gave it a positive review.

comment:10 Changed 7 years ago by schilly

spkg is on the webserver+mirros now.

comment:11 Changed 7 years ago by jdemeyer

  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:12 Changed 7 years ago by jhpalmieri

See #13126 for a follow-up.

Note: See TracTickets for help on using tickets.