Opened 8 years ago

Closed 7 years ago

#12843 closed enhancement (fixed)

Make zeromq and pyzmq optional packages

Reported by: vbraun Owned by: tbd
Priority: major Milestone: sage-5.1
Component: packages: optional Keywords: zeromq zmq 0mq pyzmq sd40.5
Cc: jason, afleckenstein, niles, benjaminfjones Merged in:
Authors: Volker Braun, William Stein Reviewers: Benjamin Jones
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The single cell server already requires zeromq+pyzmq, and the ordinary notebook server probably will soon. Since they are also useful to work with any kind of distributed memory machines, we should just make them default spkgs. They are also pretty small, about 2MB altogether.

These spkgs are based on version that William created in January 2011, but updated to the newest upstream version and include a SPKG.txt:

Change History (10)

comment:1 Changed 7 years ago by benjaminfjones

  • Keywords sd40.5 added
  • Reviewers set to Benjamin Jones

I started to review the two spkg's. zeromq-2.2.0.p0.spkg installs successfully. I unpacked and re-packaged using sage-pkg without problems. I did see some tmp files lying around:

  • SPKG.txt~
  • spkg-install~

and pyzmq-2.1.11.p0.spkg has:

  • SPKG.txt~

After install import zmq works and I experimented with some simple examples from the ZMQ guide.


If anyone wants to do some simple testing, you can grab the client and server scripts in: http://sage.math.washington.edu/home/bjones/sage-devel/zmq/, open two terminals and run:

1st terminal:

sage -python hwserver.py

2nd terminal:

sage -python hwclient.py

comment:2 Changed 7 years ago by vbraun

I updated the spkg files to remove the backup files and committed changes.

comment:3 Changed 7 years ago by benjaminfjones

Sorry, looks like we missed in zeromq:

  • .hgignore~

The pyzmq spkg looks good.


What's the procedure, after a positive review? A sage-devel vote on inclusion of the packages as standard?

comment:4 Changed 7 years ago by jason

First it should optional for some time, usually. So a vote to make it optional would usually be next.

comment:5 Changed 7 years ago by vbraun

  • Status changed from new to needs_review
  • Summary changed from Make zeromq and pyzmq standard packages to Make zeromq and pyzmq optional packages

I updated the zeromq spkg to remove the .hgignore~

I'll change this ticket to say "make optional package" and we can take it to sage-devel from there. We don't need to vote on that, only to make it standard.

comment:6 Changed 7 years ago by jdemeyer

As long as nothing else in Sage depends on zeromq, obviously zeromq should not be a standard package.

comment:7 Changed 7 years ago by benjaminfjones

  • Status changed from needs_review to positive_review

Looks good. Positive review.

comment:8 Changed 7 years ago by jdemeyer

  • Component changed from packages to optional packages

comment:9 Changed 7 years ago by schilly

both spkges are in the server's list of optional ones and on their way around the world :)

comment:10 Changed 7 years ago by jdemeyer

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.