Opened 11 years ago

Closed 11 years ago

#12838 closed defect (fixed)

Root poset should treat type A1 properly

Reported by: Christian Stump Owned by: Sage Combinat CC user
Priority: major Milestone: sage-5.1
Component: combinatorics Keywords: root poset
Cc: Merged in: sage-5.1.beta0
Authors: Christian Stump Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The patch fixes the issue that the one element root poset in type A1 was not returned correctly.

sage: Phi = RootSystem(['A',1]).root_poset(); Phi
Finite poset containing 1 elements
sage: Phi.cover_relations()
[]

I also added the facade option for root posets.

Attachments (1)

trac_12838-root_poset_A1-cs.patch (3.0 KB) - added by Jeroen Demeyer 11 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 11 years ago by Christian Stump

Status: newneeds_review

comment:2 Changed 11 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewneeds_work

In sage/combinat/root_system/root_system.py,

it should be written

- ``restricted`` -- 

(i.e. there are missing backquotes)

Otherwise, it seems ok.

Last edited 11 years ago by Frédéric Chapoton (previous) (diff)

comment:3 in reply to:  2 Changed 11 years ago by Christian Stump

Replying to chapoton:

In sage/combinat/root_system/root_system.py,

it should be written

- ``restricted`` -- 

(i.e. there are missing backquotes)

Otherwise, it seems ok.

done.

comment:4 Changed 11 years ago by Frédéric Chapoton

Status: needs_workpositive_review

comment:5 Changed 11 years ago by Jeroen Demeyer

Milestone: sage-5.0sage-5.1

comment:6 Changed 11 years ago by Jeroen Demeyer

Status: positive_reviewneeds_work

This patch needs a commit message and also needs to be rebased to sage-5.0.beta14 (or later).

comment:7 Changed 11 years ago by Jeroen Demeyer

*ping*

comment:8 in reply to:  7 Changed 11 years ago by Christian Stump

Replying to jdemeyer:

*ping*

Sorry for being slow...

I added a commit message -- the patch applies smoothly on 5.0.rc0.

Changed 11 years ago by Jeroen Demeyer

comment:9 Changed 11 years ago by Jeroen Demeyer

Not quite smoothly:

applying trac_12838-root_poset_A1-cs.patch
patching file sage/combinat/root_system/root_lattice_realizations.py
Hunk #1 succeeded at 507 with fuzz 2 (offset -34 lines).

Anyway, I rebased it.

comment:10 Changed 11 years ago by Jeroen Demeyer

Status: needs_workpositive_review

comment:11 Changed 11 years ago by Jeroen Demeyer

Merged in: sage-5.1.beta0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.