Opened 6 years ago
Closed 6 years ago
#12838 closed defect (fixed)
Root poset should treat type A1 properly
Reported by: | stumpc5 | Owned by: | sage-combinat |
---|---|---|---|
Priority: | major | Milestone: | sage-5.1 |
Component: | combinatorics | Keywords: | root poset |
Cc: | Merged in: | sage-5.1.beta0 | |
Authors: | Christian Stump | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
The patch fixes the issue that the one element root poset in type A1 was not returned correctly.
sage: Phi = RootSystem(['A',1]).root_poset(); Phi Finite poset containing 1 elements sage: Phi.cover_relations() []
I also added the facade option for root posets.
Attachments (1)
Change History (12)
comment:1 Changed 6 years ago by
- Status changed from new to needs_review
comment:2 follow-up: ↓ 3 Changed 6 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to needs_work
comment:3 in reply to: ↑ 2 Changed 6 years ago by
Replying to chapoton:
In sage/combinat/root_system/root_system.py,
it should be written
- ``restricted`` --(i.e. there are missing backquotes)
Otherwise, it seems ok.
done.
comment:4 Changed 6 years ago by
- Status changed from needs_work to positive_review
comment:5 Changed 6 years ago by
- Milestone changed from sage-5.0 to sage-5.1
comment:6 Changed 6 years ago by
- Status changed from positive_review to needs_work
This patch needs a commit message and also needs to be rebased to sage-5.0.beta14 (or later).
comment:7 follow-up: ↓ 8 Changed 6 years ago by
*ping*
comment:8 in reply to: ↑ 7 Changed 6 years ago by
Replying to jdemeyer:
*ping*
Sorry for being slow...
I added a commit message -- the patch applies smoothly on 5.0.rc0.
Changed 6 years ago by
comment:9 Changed 6 years ago by
Not quite smoothly:
applying trac_12838-root_poset_A1-cs.patch patching file sage/combinat/root_system/root_lattice_realizations.py Hunk #1 succeeded at 507 with fuzz 2 (offset -34 lines).
Anyway, I rebased it.
comment:10 Changed 6 years ago by
- Status changed from needs_work to positive_review
comment:11 Changed 6 years ago by
- Merged in set to sage-5.1.beta0
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
In sage/combinat/root_system/root_system.py,
it should be written
(i.e. there are missing backquotes)
Otherwise, it seems ok.