Opened 10 years ago

Closed 10 years ago

#12829 closed defect (fixed)

Remove <object> cast in real_mpfi.pyx

Reported by: jdemeyer Owned by: drkirkby
Priority: critical Milestone: sage-5.0
Component: porting Keywords: ppc64 big endian mpfi
Cc: Merged in: sage-5.0.beta14
Authors: Paul Zimmermann, Jeroen Demeyer Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The following is very wrong code (from sage/rings/real_mpfi.pyx)

# todo: The <object> coerce is evidently to get around a weird bug in SageX (?)   
mpfi_interv_q(self.value, <object>rat.value, <object>rat1.value) 

Surprisingly, it only breaks on PPC64. See #11705 for more context.

Attachments (1)

12829_mpfi.patch (7.3 KB) - added by jdemeyer 10 years ago.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by jdemeyer

comment:1 Changed 10 years ago by jdemeyer

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by fbissey

  • Status changed from needs_review to positive_review

Works for me on the power7 box I have access to.

comment:3 Changed 10 years ago by jdemeyer

  • Reviewers set to François Bissey

comment:4 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.0.beta14
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.