Changes between Version 8 and Version 29 of Ticket #12823


Ignore:
Timestamp:
04/13/12 19:03:53 (8 years ago)
Author:
john_perry
Comment:

I've attached another patch that

  • removes remove_constraints() from mip.pyx,
  • incorporates a generic remove_constraints() into generic_backend.pyx, more or less along the lines of what you were doing with CPLEX and gurobi, but
  • retains the definitions of remove_constraints() used previously in coin_backend.pyx and glpk_backend.pyx, taking advantage of their respective optimizations.

The CPLEX & Gurobi patch can be changed so that only remove_constraint() need be defined. If you prefer, we could rename that to remove_single_constraint(). This eliminates some code duplication, though not much. I think the tradeoff is worth the trouble, myself.

Oh -- notice that I still have the old WARN:: and so on in there. I'll change it to the way you had it, if you're okay with this approach. I have a meeting now, but I wanted to get this out so you could look at it & consider it.

Or, we can stick with the older patches.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12823

    • Property Status changed from needs_review to needs_info
    • Property Work issues changed from to failing doctests
  • Ticket #12823 – Description

    v8 v29  
    2222  * [attachment:trac_12823_const_for_obj_funs.patch]
    2323  * [attachment:trac_12823-cplex_gurobi.patch]
     24'''or'''
     25  * [attachment:trac_12823_alternate_removal.patch]