Opened 10 years ago

Closed 10 years ago

#12805 closed defect (fixed)

Do not create SAGE_TESTDIR/tmp

Reported by: jhpalmieri Owned by: mvngu
Priority: blocker Milestone: sage-5.0
Component: doctest coverage Keywords: sage-test SAGE_TESTDIR tmp
Cc: leif Merged in: sage-5.0.beta13
Authors: John Palmieri Reviewers: Leif Leonhardy
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jhpalmieri)

The script sage-test creates the directory SAGE_TESTDIR/tmp, and then that directory is never used for anything. Its presence, combined with the doctests from #12069, results in the temporary doctesting directory (created by sage -tp ... or make ptestlong, for example) to be nonempty, and therefore not deleted after doctesting, even if all tests passed.

Apply trac_12805-no-tmp.patch to the scripts repository.

Attachments (1)

trac_12805-no-tmp.patch (1.1 KB) - added by jhpalmieri 10 years ago.
scripts repo

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by jhpalmieri

scripts repo

comment:1 Changed 10 years ago by jhpalmieri

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 10 years ago by jhpalmieri

A few ways to test this:

  1. Remove the directory DOT_SAGE/tmp, and then doctest a single file: ./sage -t devel/sage/sage/tests/ If you haven't applied the patch, then after testing has completed, you should see DOT_SAGE/tmp (which is SAGE_TESTDIR) but also DOT_SAGE/tmp/tmp (which is useless). After applying the patch, this last directory should not be present.
  2. Run ./sage -tp devel/sage/sage/tests/ If you haven't applied the patch, you should see a message like
    sage -t --long devel/sage/sage/tests/
    	 [24.3 s]
    The temporary doctesting directory
    was not removed: it is not empty, presumably because doctests
    failed or doctesting was interrupted.
    All tests passed!
    Total time for all tests: 24.3 seconds
    If you have applied the patch, then you won't see the part about the directory not being empty.

comment:3 Changed 10 years ago by leif

  • Authors set to John Palmieri
  • Reviewers set to Leif Leonhardy
  • Status changed from needs_review to positive_review

Thanks, works as expected.

comment:4 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.0.beta13
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.