Opened 7 years ago
Closed 7 years ago
#12805 closed defect (fixed)
Do not create SAGE_TESTDIR/tmp
Reported by: | jhpalmieri | Owned by: | mvngu |
---|---|---|---|
Priority: | blocker | Milestone: | sage-5.0 |
Component: | doctest coverage | Keywords: | sage-test SAGE_TESTDIR tmp |
Cc: | leif | Merged in: | sage-5.0.beta13 |
Authors: | John Palmieri | Reviewers: | Leif Leonhardy |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
The script sage-test
creates the directory SAGE_TESTDIR/tmp
, and then that directory is never used for anything. Its presence, combined with the doctests from #12069, results in the temporary doctesting directory (created by sage -tp ...
or make ptestlong
, for example) to be nonempty, and therefore not deleted after doctesting, even if all tests passed.
Apply trac_12805-no-tmp.patch to the scripts repository.
Attachments (1)
Change History (5)
Changed 7 years ago by
comment:1 Changed 7 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
A few ways to test this:
- Remove the directory
DOT_SAGE/tmp
, and then doctest a single file:./sage -t devel/sage/sage/tests/arxiv_0812_2725.py
. If you haven't applied the patch, then after testing has completed, you should seeDOT_SAGE/tmp
(which isSAGE_TESTDIR
) but alsoDOT_SAGE/tmp/tmp
(which is useless). After applying the patch, this last directory should not be present. - Run
./sage -tp devel/sage/sage/tests/cmdline.py
. If you haven't applied the patch, you should see a message likesage -t --long devel/sage/sage/tests/cmdline.py [24.3 s] ---------------------------------------------------------------------- The temporary doctesting directory /Users/palmieri/.sage/tmp/jpalmieri538.math.washington.edu-92341 was not removed: it is not empty, presumably because doctests failed or doctesting was interrupted. ---------------------------------------------------------------------- All tests passed! Total time for all tests: 24.3 seconds
If you have applied the patch, then you won't see the part about the directory not being empty.
comment:3 Changed 7 years ago by
- Reviewers set to Leif Leonhardy
- Status changed from needs_review to positive_review
Thanks, works as expected.
comment:4 Changed 7 years ago by
- Merged in set to sage-5.0.beta13
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
scripts repo