Changes between Version 3 and Version 8 of Ticket #12768


Ignore:
Timestamp:
Apr 10, 2012, 3:37:04 PM (11 years ago)
Author:
cremona
Comment:

Review: This patch implements three different things: (1) A new class for isogeny classes of elliptic curves (currently only for curves over Q); (2) implementation of the new (March 2012) LMFDB labels for elliptic curves over Q, with utilities for comverting to and from Cremona labels; (3) better layouts for isogeny graphs of elliptic curves over Q.

I have been through the code in some detail and only found some minor things to fix, as in the reviewer's patch. One of these was a typo causing doctest failure. Nothing more than minor. If David R is happy with these, I'll give the ticket a positive review.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #12768

    • Property Dependencies changed from to #12769
    • Property Reviewers changed from to John Cremona

  • Ticket #12768 – Description

    v3 v8  
    11There are only 17 different possible isogeny graphs for elliptic curves over Q.  It would be nice if the isogeny graph was laid out in the same way each time, and if the labels corresponded to the Cremona labels of the curves in the isogeny class.
    22
    3 The second major topic handled by this ticket is to implement handling of LMFDB labels for elliptic curves as well as Cremona labels, and the conversions between these.
     3The second major topic handled by this ticket is to implement handling of LMFDB labels for elliptic curves as well as Cremona labels, and the conversions between these.  the third is a new class for isogeny classes of elliptic curves over Q.
     4
     5Apply: 12768.patch, 12768-review.patch