Opened 12 years ago

Closed 11 years ago

#1276 closed enhancement (wontfix)

[with patches, needs review] incorporate willem's doctest timing code into sage

Reported by: was Owned by: gfurnish
Priority: blocker Milestone: sage-3.1.2
Component: doctest coverage Keywords: editor_mabshoff
Cc: wjp Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

> Send me your doctest timing code :-)  I'm looking forward to playing with it.

Here you go. It's a patch to local/bin/sage-doctest and a file timing.py
that I had put in sage/misc .

It adds a --time option to sage-doctest that makes it append the timings
it generates as a dict indexed by hash to the (cpickled) file
.doctest/timings.sobj .  There's no infrastructure yet to automatically
delete that file when appropriate, though.

I also attached two very basic scripts that show or compare the contents
of timings.sobj files.

Attachments (3)

recodefordoctesttiming.zip (2.5 KB) - added by was 12 years ago.
trac_1276.patch (2.2 KB) - added by gfurnish 12 years ago.
rebased & fixed devel repo patch for this.
trac_1276_scripts.patch (3.5 KB) - added by gfurnish 12 years ago.
rebased & fixed scripts repo patch for this.

Download all attachments as: .zip

Change History (14)

Changed 12 years ago by was

comment:1 Changed 12 years ago by was

  • Owner changed from failure to was

comment:2 Changed 12 years ago by mabshoff

  • Milestone changed from sage-2.10 to sage-2.9.2
  • Summary changed from incorporate willem's doctest timing code into sage to [with patches, needs review] incorporate willem's doctest timing code into sage

This ought to get merged.

Cheers,

Michael

comment:3 Changed 12 years ago by ncalexan

  • Owner changed from was to ncalexan

This code looks good, and I'm working in this area so I'll update it and ready it for merging.

comment:4 Changed 12 years ago by wjp

  • Cc wjp added

comment:5 Changed 12 years ago by rlm

  • Milestone changed from sage-2.11 to sage-2.10.4

comment:6 Changed 12 years ago by mabshoff

  • Milestone changed from sage-3.0.1 to sage-3.0
  • Priority changed from major to blocker

comment:7 Changed 12 years ago by was

  • Milestone changed from sage-3.0 to sage-3.0.1

Changed 12 years ago by gfurnish

rebased & fixed devel repo patch for this.

Changed 12 years ago by gfurnish

rebased & fixed scripts repo patch for this.

comment:8 Changed 12 years ago by gfurnish

  • Owner changed from ncalexan to gfurnish
  • Status changed from new to assigned

comment:9 Changed 11 years ago by craigcitro

  • Keywords editor_mabshoff added

comment:10 Changed 11 years ago by ncalexan

I think that ticket #3476 does the actual "write time info to file" better than this patch, but the viewing scripts here are useful and should be kept.

I suggest basing this ticket on #3476.

comment:11 Changed 11 years ago by mabshoff

  • Resolution set to wontfix
  • Status changed from assigned to closed

This superseded by #3476, so let's close this.

Cheers,

Michael

Note: See TracTickets for help on using tickets.