Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12750 closed defect (fixed)

Fix scoping / name look-up issue in PolyBoRi 0.8.0 and support flags from the environment

Reported by: AlexanderDreyer Owned by: AlexanderDreyer
Priority: major Milestone: sage-5.0
Component: algebra Keywords: C++11 GCC 4.7.0 CXXFLAGS -fpermissive
Cc: leif, PolyBoRi, malb, burcin Merged in: sage-5.0.beta12
Authors: Alexander Dreyer Reviewers: Leif Leonhardy
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by AlexanderDreyer)

The following was found out here: http://groups.google.com/group/sage-release/browse_thread/thread/e2a87c73dc1625f2

* PolyBoRi fails to build due to stricter (C++11) scoping / name look-up rules.
    Unfortunately PolyBoRi doesn't honor CXXFLAGS, so I had to use CXX="g++-4.7.0 -fpermissive" to make the spkg build. 

The scoping issue should be fixed here: https://bitbucket.org/brickenstein/polybori/changeset/43b3931ceed7/raw/

Also, we should support CXXFLAGS and CFLAGS (ANd CPPFLAGS?) in the spkg.

Current spkg

Change History (15)

comment:1 Changed 9 years ago by AlexanderDreyer

  • Description modified (diff)
  • Owner changed from AlexGhitza to AlexanderDreyer

comment:2 Changed 9 years ago by leif

  • Keywords C++11 GCC 4.7.0 CXXFLAGS -fpermissive added

comment:3 Changed 9 years ago by leif

  • Status changed from new to needs_review

comment:4 Changed 9 years ago by AlexanderDreyer

  • Cc PolyBoRi malb burcin added
  • Owner changed from AlexanderDreyer to (none)

comment:5 Changed 9 years ago by AlexanderDreyer

  • Owner changed from (none) to AlexanderDreyer

comment:6 follow-up: Changed 9 years ago by leif

  • Reviewers set to Leif Leonhardy
  • Status changed from needs_review to positive_review

Works as advertised, i.e., builds with GCC 4.7.0 (without -fpermissive) and also honors CXXFLAGS in the C++ compile commands (although I have to admit I haven't checked all of them, just a couple). Also passes its test suite.

I haven't really looked at the new spkg itself though, but I expect it to have no flaws... ;-)

comment:7 in reply to: ↑ 6 Changed 9 years ago by leif

  • Status changed from positive_review to needs_work
  • Work issues set to Update `SPKG.txt`.

Replying to leif:

I haven't really looked at the new spkg itself though, but I expect it to have no flaws... ;-)

Ok, did so. "Global" CFLAGS, CPPFLAGS and CXXFLAGS are properly added now, and upstream patches fixing the name look-up issue get applied.

The last revision isn't tagged yet (which the merge script then will do later), but more importantly, SPKG.txt lacks a new changelog entry.

Last edited 9 years ago by leif (previous) (diff)

comment:8 Changed 9 years ago by AlexanderDreyer

I forgot that in the first. I immediately replaced it the spkg, but maybe it was cached somewhere, s.th. you might have to reload it.

The latest entry is as follows:

=== polybori-0.8.0.p2 (Alexander Dreyer, March 26th, 2012) ===
 * Fix scoping/name look-up issue and support flags from the environment

comment:9 Changed 9 years ago by AlexanderDreyer

  • Status changed from needs_work to needs_review

comment:10 follow-ups: Changed 9 years ago by leif

  • Status changed from needs_review to positive_review
  • Work issues Update `SPKG.txt`. deleted

Replying to AlexanderDreyer:

I forgot that in the first. I immediately replaced it the spkg, but maybe it was cached somewhere, s.th. you might have to reload it.

Well, the updated one is nearly 5 hours younger... ;-)

comment:11 in reply to: ↑ 10 Changed 9 years ago by AlexanderDreyer

Replying to leif:

Replying to AlexanderDreyer:

I forgot that in the first. I immediately replaced it the spkg, but maybe it was cached somewhere, s.th. you might have to reload it.

Well, the updated one is nearly 5 hours younger... ;-)

Right, 'immediately' in a philosophical manner ;-) No, sorry I had had trouble connecting to boxen then.

comment:12 in reply to: ↑ 10 Changed 9 years ago by AlexanderDreyer

Replying to leif:

Replying to AlexanderDreyer:

I forgot that in the first. I immediately replaced it the spkg, but maybe it was cached somewhere, s.th. you might have to reload it.

Well, the updated one is nearly 5 hours younger... ;-)

Can you also have a look at #12754 for PolyBoRi 0.8.1?

comment:13 Changed 9 years ago by jdemeyer

  • Authors changed from AlexanderDreyer to Alexander Dreyer

comment:14 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta12
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:15 Changed 9 years ago by jdemeyer

  • Summary changed from Fix scoping / name look-up issue und PolyBoRi 0.8.0 and support flags from the envrionment to Fix scoping / name look-up issue in PolyBoRi 0.8.0 and support flags from the environment
Note: See TracTickets for help on using tickets.