Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#12742 closed defect (fixed)

matplotlib must be a dependency of cvxopt

Reported by: dimpase Owned by: tbd
Priority: blocker Milestone: sage-5.0
Component: packages: standard Keywords: cvxopt matplotlib
Cc: Merged in: sage-5.0.beta11
Authors: Jeroen Demeyer Reviewers: Julien Puydt
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #10492 Stopgaps:

Status badges

Description (last modified by jdemeyer)

see https://groups.google.com/d/msg/sage-release/4qh8c9wWJfI/XgVZxmu7zu8J

SAGE_CHECK will fail on cvxopt if pylab (part of matplotlib) is not available.

Apply 12742_cvxopt_deps.patch to SAGE_ROOT.

Attachments (1)

12742_cvxopt_deps.patch (779 bytes) - added by jdemeyer 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by kcrisman

  • Description modified (diff)
  • Keywords matplotlib added; mathplotlib removed
  • Work issues changed from make mathplotlib a pre-req for cvxopt to make matplotlib a pre-req for cvxopt

comment:2 Changed 10 years ago by jdemeyer

  • Dependencies set to #10492
  • Priority changed from major to blocker
  • Summary changed from mathplotlib must be a dependence of cvxopt to matplotlib must be a dependence of cvxopt

Changed 10 years ago by jdemeyer

comment:3 Changed 10 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from matplotlib must be a dependence of cvxopt to matplotlib must be a dependency of cvxopt
  • Work issues make matplotlib a pre-req for cvxopt deleted

comment:4 Changed 10 years ago by Snark

  • Status changed from needs_review to positive_review

This patch looks good.

comment:5 Changed 10 years ago by jdemeyer

  • Reviewers set to Julien Puydt

comment:6 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.0.beta11
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 follow-up: Changed 10 years ago by leif

There should at least be a comment that (building) CVXOPT does not depend on matplotlib; if upstream fixes the tests (e.g. by skipping some in case matplotlib is not [yet] available), this dependency should get removed again.

Also CVXOPT's SPKG.txt should get updated accordingly ("Dependencies" and "Special Update/Build? Instructions" sections).

comment:8 Changed 10 years ago by jhpalmieri

See #12784 for a trivial-to-review followup.

Adding a comment to cvxopt's SPKG.txt should perhaps also be done. The same could be said for sagetex's SPKG.txt, which doesn't explain that testing the package will fail unless basically all of Sage is installed first. Someone else can deal with those.

comment:9 in reply to: ↑ 7 Changed 10 years ago by jdemeyer

Replying to leif:

if upstream fixes the tests

I don't think there is anything to be "fixed" upstream.

Note: See TracTickets for help on using tickets.