Changes between Initial Version and Version 7 of Ticket #12737


Ignore:
Timestamp:
04/14/12 23:02:04 (8 years ago)
Author:
mjo
Comment:

This should be a more straight-forward proposal. I just removed simplify_radical() from simplify_full() and fixed a few doctests (details in the commit message).

One of the doctest fixes is duplicated in #12780; the doctest is wrong (missing assumptions) but we're masking that fact at the moment.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12737

    • Property Status changed from new to needs_review
    • Property Dependencies changed from #12650 to
    • Property Summary changed from Add an `unsafe` argument to Expression.simplify_full() to Remove simplify_radical() from simplify_full()
    • Property Authors changed from to Michael Orlitzky
  • Ticket #12737 – Description

    initial v7  
    1 Followup to #12650. There are a number of tickets open due to the use of `simplify_radical()` in `simplify_full()`. By adding an `unsafe` argument, we make sure the user really knows what he's doing.
     1There are a number of tickets open due to the use of `simplify_radical()` in `simplify_full()`.
    22
    3 For example,
    4 
    5 {{{
    6 sage: f = sqrt( (x+1)^2 )         
    7 sage: f.full_simplify(unsafe=True)
    8 x + 1
    9 }}}
    10 
    11 This will fix at least,
     3Removing it would fix at least,
    124
    135 * [http://ask.sagemath.org/question/767/simplification-errors-in-simple-expressions Ask Sage 767]